[IMP] pivot: add icon to sort pivot #5363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
commented
Dec 17, 2024
hokolomopo
force-pushed
the
master-pivot-sort-icon-adrm
branch
from
ef48607 to
94c776d
Compare
hokolomopo
commented
Jan 6, 2025
Comment on lines
+20
to
+35
| this.store.addIconProvider({ | ||
| component: FilterIcon, | ||
| hasIcon: (getters, cellPosition) => getters.isFilterHeader(cellPosition), | ||
| type: "rightIcon", | ||
| }); | ||
| this.store.addIconProvider({ | ||
| component: DataValidationCheckbox, | ||
| hasIcon: (getters, cellPosition) => getters.isCellValidCheckbox(cellPosition), | ||
| type: "exclusiveIcon", | ||
| }); | ||
| this.store.addIconProvider({ | ||
| component: DataValidationListIcon, | ||
| hasIcon: (getters, cellPosition) => | ||
| !getters.isReadonly() && getters.cellHasListDataValidationIcon(cellPosition), | ||
| type: "rightIcon", | ||
| }); |
There was a problem hiding this comment.
Having the overlay having to register its own providers is not the best, ideally it shouldn't have to know about them ... But we need to register them somewhere (in a component) 🤷
There was a problem hiding this comment.
Maybe we can have a register of icon providers somewhere and then the overlay can add all of the entries of this register in the store ?
Since 18.1, we can sort the pivot on any column. But the feature is only discoverable through the context menu of pivot cells. With this commit, we display icons that sort a pivot when its side panel is open. The icons are that were previously displayed in the `FilterOverlay` and the `DataValidationOverlay` are now displayed in the `GridCellIconOverlay`. This overlay is based on a store where we can register icon providers. The auto-resize feature also had to be transformed into a store since it depends on the grid icons. Task: 4281154
hokolomopo
force-pushed
the
master-pivot-sort-icon-adrm
branch
from
94c776d to
6f99bcf
Compare
anhe-odoo
reviewed
Jan 9, 2025
Comment on lines
+20
to
+35
| this.store.addIconProvider({ | ||
| component: FilterIcon, | ||
| hasIcon: (getters, cellPosition) => getters.isFilterHeader(cellPosition), | ||
| type: "rightIcon", | ||
| }); | ||
| this.store.addIconProvider({ | ||
| component: DataValidationCheckbox, | ||
| hasIcon: (getters, cellPosition) => getters.isCellValidCheckbox(cellPosition), | ||
| type: "exclusiveIcon", | ||
| }); | ||
| this.store.addIconProvider({ | ||
| component: DataValidationListIcon, | ||
| hasIcon: (getters, cellPosition) => | ||
| !getters.isReadonly() && getters.cellHasListDataValidationIcon(cellPosition), | ||
| type: "rightIcon", | ||
| }); |
There was a problem hiding this comment.
Maybe we can have a register of icon providers somewhere and then the overlay can add all of the entries of this register in the store ?
| this.model.dispatch("RESIZE_COLUMNS_ROWS", { | ||
| elements: [row], | ||
| dimension: "ROW", | ||
| size: null, |
There was a problem hiding this comment.
Why don't we compute the size according to the content, as done for the columns ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4281154
review checklist