Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] figures: add anchor to figures #5356

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fdamhaut
Copy link
Contributor

@fdamhaut fdamhaut commented Dec 16, 2024

Description:

[IMP] figures: add anchor to figures

Add possibilities for chart to be anchored to the
top-left corner cell. If a cell is anchored, it
will be moving with the cell on modification of the sheet
(i.e. col/row addition/deletion).

The figure can still have a fixed position, this will act
as if the anchor is placed in the left-most, top-most cell.

Task: 4189170

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Dec 16, 2024

Pull request status dashboard

@fdamhaut fdamhaut force-pushed the master-spreadsheet-figure-anchor-flda branch 2 times, most recently from 953eccc to ae1c333 Compare January 6, 2025 15:24
@fdamhaut fdamhaut force-pushed the master-spreadsheet-figure-anchor-flda branch 8 times, most recently from 367b2a5 to 5a6f1ee Compare January 15, 2025 15:56
Add possibilities for chart to be anchored to the
top-left corner cell. If a cell is anchored, it
will be moving with the cell on modification of the sheet
(i.e. col/row addition/deletion).

The figure can still have a fixed position, this will act
as if the anchor is placed in the left-most, top-most cell.

Task: 4189170
@fdamhaut fdamhaut force-pushed the master-spreadsheet-figure-anchor-flda branch from 5a6f1ee to 75c2c36 Compare January 16, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants