Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] smooth scroll #4111

Closed
wants to merge 5 commits into from
Closed

[WIP] smooth scroll #4111

wants to merge 5 commits into from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Apr 22, 2024

qqsd

qsd

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Apr 22, 2024

@rrahir rrahir force-pushed the master-smooth-scroll-rar branch 2 times, most recently from e20e165 to 799ea43 Compare April 22, 2024 19:04
@rrahir rrahir force-pushed the master-smooth-scroll-rar branch 4 times, most recently from 79b8560 to d7a09ce Compare January 1, 2025 20:05
rrahir added 3 commits January 1, 2025 21:13
TODO:
- check that we could simply (maybe) stop snapping?
- write some tests
- Add a mode toggle
- refactor the shitshow (looks expensive for no reason)
- Fix the frozen pane behaviour without breaking the current
il faut deux concepts indépendants - il y a le box.computeDimension
et le box.drawDimension et ils sont indépendants
@rrahir rrahir force-pushed the master-smooth-scroll-rar branch from d7a09ce to aeddf8d Compare January 2, 2025 08:30
@rrahir
Copy link
Collaborator Author

rrahir commented Jan 7, 2025

dropped in favor of #5416

@rrahir rrahir closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants