Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify styled component advice for theme specific assets #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify styled component advice for theme specific assets #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,8 @@ which is then more helpful in the component. The component only ever has to care


#### <a name='theme-specific-assets'>Example which needs some theme specific asset</a>

Instead of doing this:
```
${theme=='octopus' &&
css`
Expand Down Expand Up @@ -557,7 +559,7 @@ which is then used like this in e.g the octopus theme file:
```
primaryBanner: bannerMixin({
backgroundColor: backgroundPrimary,
backgroundUrl: 'something/octopus/specific'
backgroundUrl: 'something/octopus/specific' // so this path only appears in the octopus theme file
}),
```

Expand Down