Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints phys equal #1745

Draft
wants to merge 1 commit into
base: hints
Choose a base branch
from
Draft

Hints phys equal #1745

wants to merge 1 commit into from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Nov 25, 2024

Fix #1372

@TyOverby
Copy link
Collaborator

There's a lot of unexpected changes in this PR, I think you may need to rebase it?

@hhugo
Copy link
Member Author

hhugo commented Nov 25, 2024

This PR is based on #1721

@hhugo hhugo marked this pull request as draft November 25, 2024 16:47
@smorimoto smorimoto changed the base branch from master to hints November 28, 2024 13:08
@smorimoto
Copy link
Member

Now, when you merge the hints branch, this PR will automatically be directed to master branch.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • compiler/lib/generate.ml: Language not supported
  • compiler/lib/parse_bytecode.ml: Language not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Object.is instead of === to implement phys_equal
3 participants