Add the Made by Observable button to the top nav #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Oct 9, 2024
Comment on lines
45
to
50
| /* Hide the dark mode toggle */ | ||
| .VPNavBarAppearance, | ||
| .VPNavBarExtra, | ||
| .VPNavBarHamburger { | ||
| display: none !important; | ||
| } |
There was a problem hiding this comment.
This shouldn’t be necessary with appearance: "force-auto"?
There was a problem hiding this comment.
Or maybe the comment only applied to .VPNavBarAppearance, whereas we still also want to hide .VPNavBarExtra and .VPNavBarHamburger? Although it makes me wonder what functionality we are losing by hiding those latter two things?
There was a problem hiding this comment.
Yup, .VPNavBarAppearance is not needed anymore (removed it). In terms of what we are missing from the othhers, they are actually empty with our implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Made by Observable component to the Plot site.