Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typedoc for integrations/* packages too #424

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Use typedoc for integrations/* packages too #424

merged 2 commits into from
Oct 3, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Oct 1, 2024 •
edited
Loading

This PR:

  • fixes typedoc generation (regression in Add Viem v2 & Wagmi v2 packages, and remove Ethers dependency #303)
  • bumps typedoc to the latest 0.25.13 (existing 0.25.4 version seems to ignore typedocOptions.out property in tsconfig.json)
  • adds typedoc to all npm integrations packages too
  • deploys all those packages to api-reference branch
  • bumps wagmi and wagmi/core dependencies in all workspaces to 2.x

Needed to unblock oasisprotocol/oasis-sdk#1971

I already compiled and published API docs for debugging: PREVIEW

@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit 4298613
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66fe6ac487243000086b84c2

@matevz matevz force-pushed the matevz/docs/typedoc branch from 8c7e4d1 to d456de6 Compare October 2, 2024 14:10
@matevz matevz changed the title Add typedoc to integrations Use typedoc for integrations/* packages too Oct 2, 2024
@matevz matevz force-pushed the matevz/docs/typedoc branch 3 times, most recently from 7f1cc17 to ff12dd6 Compare October 2, 2024 17:17
@matevz matevz marked this pull request as draft October 2, 2024 17:31
@matevz matevz force-pushed the matevz/docs/typedoc branch 2 times, most recently from 32defe5 to a374ad2 Compare October 2, 2024 18:52
@matevz matevz force-pushed the matevz/docs/typedoc branch from a374ad2 to f82dfc3 Compare October 2, 2024 19:09
@matevz matevz marked this pull request as ready for review October 2, 2024 19:09
@matevz matevz requested review from rube-de, aefhm and CedarMist October 2, 2024 19:13
@CedarMist
Copy link
Member

Types of parameters 'config' and 'config' are incompatible.

Effing wagmi causing type errors

@matevz matevz merged commit f708f39 into main Oct 3, 2024
10 checks passed
@matevz matevz deleted the matevz/docs/typedoc branch October 3, 2024 10:41
github-actions bot added a commit that referenced this pull request Oct 3, 2024
@github-actions
Deploy sol API reference Merge pull request #424 from oasisprotocol/m…
d15da91 
…atevz/docs/typedoc

Use typedoc for integrations/* packages too f708f39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CedarMist CedarMist CedarMist approved these changes

@rube-de rube-de Awaiting requested review from rube-de

@aefhm aefhm Awaiting requested review from aefhm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matevz @CedarMist