Add support for merging all networks in the layer selector #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can hide different layers on different networks.
Include the name of the network for all layer menu items, therefore eliminating the dependency of the layer menu on the network menu. The goal is that in the future, we can show the layer menu items in other arrangements, not strictly following the separation of the different networks. Also, clean up internal architecture a naming a little bit. There should be no functionality change.
Deployed to Cloudflare Pages
|
Please note that this only make sense if you don't have layers that are named the same on multiple networks. (If you do, you can override names using the spacialScopeNames config option in config.ts.)
csillag
force-pushed
the
csillag/support-flattened-layer-menu
branch
from
10c551a to
3455e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #1686.
This PR adds support for merging all networks in the layer selector,
so that instead of a hierarchical menu, we get a flat one.
On the Pontus-X instance, using this feature, instead of this:
and this:
We can have this:
Please note that you only want to activate this if you don't have
layers that are named the same on multiple networks.
(If you do, you can override names using the spacialScopeNames
config option in config.ts.)
Merging this PR doesn't change behavior, unless to turn the
mergeNetworksInLayerSelectorflag from false to true.