Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case sensitivity in Pontus-X account name resolution #1685

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix case sensitivity in Pontus-X account name resolution #1685

merged 1 commit into from
Jan 14, 2025
+3 −2

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jan 13, 2025 •
edited
Loading

This fix has been in production on the Pontus-X branch (and instance) for a while, now pulling it to the master branch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 3ce27d9317002c9e8aef5bea82a20f29353f0476
Status:✅ Deploy successful!
Preview URL: https://ed628382.oasis-explorer.pages.dev
Alias: https://pr-1685.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/fix-pontusx-account-name-case-sensitivity branch from 3ff1709 to 5a3a77f Compare January 13, 2025 15:22
@csillag csillag marked this pull request as ready for review January 13, 2025 15:23
@csillag csillag force-pushed the csillag/fix-pontusx-account-name-case-sensitivity branch from 5a3a77f to 3ce27d9 Compare January 14, 2025 02:43
@csillag csillag enabled auto-merge January 14, 2025 02:50
lukaw3d
lukaw3d approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. But I thought we normalize all addresses into checksum capitalization 🤷

@csillag csillag merged commit 336b2ef into master Jan 14, 2025
8 checks passed
@csillag csillag deleted the csillag/fix-pontusx-account-name-case-sensitivity branch January 14, 2025 13:14
@csillag csillag mentioned this pull request Jan 15, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

@lubej lubej Awaiting requested review from lubej lubej is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csillag @lukaw3d