change the logic little bit

Signed-off-by: Andrea Waltlova <[email protected]>

src/runner.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"bufio"
 	"errors"
 	"fmt"
 	"io"
@@ -109,26 +110,28 @@ func runCommandWithOutput(cmd *exec.Cmd, outputCh chan string, doneCh chan bool)
 		return
 	}
 
+	dataReadCh := make(chan bool)
+	defer close(dataReadCh)
+
 	go func() {
-		// NOTE: This could be set by config or by env variable in received yaml
-		var bufferSize = 256
-		buf := make([]byte, bufferSize)
+		defer func() {
+			dataReadCh <- true
+		}()
+
+		reader := bufio.NewReader(cmdOutput)
+
 		for {
-			log.Infoln("Writing to buffer ...")
-			n, err := cmdOutput.Read(buf)
-			log.Infoln("Buffer full ...")
-
-			if err != nil {
-				if errors.Is(err, io.EOF) {
-					log.Infoln("Command stdout closed")
-					return
-				}
-				log.Infoln("Error after buffer closed")
+			line, err := reader.ReadString('\n')
+			if errors.Is(err, io.EOF) {
+				log.Infoln("Read ended with EOF")
+				break
+			} else if err != nil {
+				log.Infoln("Read ended with error", err)
+				outputCh <- fmt.Sprintf("Error reading from stdout: %v", err)
 				return
 			}
-			log.Infoln("Writing data to output channel ...")
-			outputCh <- string(buf[:n])
-			buf = make([]byte, bufferSize)
+			log.Infoln("Read line: ", line)
+			outputCh <- line
 		}
 	}()
 
@@ -138,6 +141,10 @@ func runCommandWithOutput(cmd *exec.Cmd, outputCh chan string, doneCh chan bool)
 		return
 	}
 
+	// NOTE: need to block here before goroutine finishes so wait doesn't close the stdout pipe
+	log.Infoln("Waiting to collect all stdout from running command")
+	<-dataReadCh
+
 	if err := cmd.Wait(); err != nil {
 		log.Errorln("Failed to execute script: ", err)
 		outputCh <- fmt.Sprintf("Error: %v", err)