Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/replace prints by logging #18

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Conversation

andywaltlova
Copy link
Collaborator

OAMG-10974

Signed-off-by: Andrea Waltlova <[email protected]>
Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova andywaltlova force-pushed the feat/replace-prints-by-logging branch from ebd3818 to e6dfb7b Compare June 27, 2024 13:21
@andywaltlova andywaltlova requested a review from r0x0d June 27, 2024 13:21
@andywaltlova
Copy link
Collaborator Author

@r0x0d I think this should be last changes that we did in c2r tasks that are not here - logging + sos report (I know we did some changes in RequiredFile class but we do not use it here).

I am just updating it to reduce the risk of repeating same issues that we already solved with c2r tasks because of the expected preupgrade task move to prod env.

Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my pov

Signed-off-by: Andrea Waltlova <[email protected]>
@andywaltlova andywaltlova merged commit 49f4fe9 into main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants