Changes to support the demo #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jzonthemtn <[email protected]>
jzonthemtn
commented
Dec 10, 2024
| @@ -276,6 +276,7 @@ public void indexClickthroughRates(final Map<String, Set<ClickthroughRate>> clic | |||
| jsonMap.put("clicks", clickthroughRate.getClicks()); | |||
| jsonMap.put("events", clickthroughRate.getEvents()); | |||
| jsonMap.put("ctr", clickthroughRate.getClickthroughRate()); | |||
| jsonMap.put("object_id", clickthroughRate.getObjectId()); | |||
There was a problem hiding this comment.
The object_id was not being indexed for a clickthrough rate.
jzonthemtn
commented
Dec 10, 2024
|
|
||
| request.add(indexRequest); | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| client.bulk(request).get(); | ||
| client.bulk(request, new ActionListener<>() { |
There was a problem hiding this comment.
To avoid a blocking thread.
Signed-off-by: jzonthemtn <[email protected]>
jzonthemtn
commented
Dec 10, 2024
| @@ -137,7 +135,10 @@ public String sample() throws Exception { | |||
| // This may require generating more random numbers than what was requested | |||
| // because removing duplicate user queries will require randomly picking more queries. | |||
| int count = 1; | |||
| while(querySet.size() < parameters.getQuerySetSize() && count < userQueries.size()) { | |||
|
|
|||
| // TODO: How to short-circuit this such that if the same query gets picked over and over, the loop will never end. | |||
There was a problem hiding this comment.
The issue of short-circuiting the PPTSS sampling for when the same user query gets picked over and over and over...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.