Getting judgments for metrics calculation. Improving error handling and validation. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
approved these changes
Dec 4, 2024
data/esci/index.sh
Outdated
There was a problem hiding this comment.
i wonder if we shoulid call this dir sample-data to reflect that it isn't "real data shipped with the plugin"?
There was a problem hiding this comment.
Agreed. This is kind of what sparked my thought about having data external. I don't want another repo, but it's almost to the point where putting data somewhere else would be helpful.
| @@ -329,7 +333,7 @@ public String indexJudgments(final Collection<Judgment> judgments) throws Except | |||
| final Map<String, Object> judgmentsSource = new HashMap<>(); | |||
| judgmentsSource.put("judgments", j); | |||
|
|
|||
| final IndexRequest indexRequest = new IndexRequest(INDEX_JUDGMENTS) | |||
| final IndexRequest indexRequest = new IndexRequest(JUDGMENTS_INDEX_NAME) | |||
There is one but I think it's more management stuff. We might be better off making a "search relevance CLI." |
Signed-off-by: jzonthemtn <[email protected]>
Signed-off-by: jzonthemtn <[email protected]>
Signed-off-by: jzonthemtn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting judgments for metrics calculation. Improving error handling and validation