Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two commits
--
oracle.asm
--
oracle_kzg.asm
--
oracle_unaligned_read.asm
--
oracle_unaligned_write.asm
SyscallWritePreimage
handler to get tests to passThe test was adapted from the cannon codebase version. None of these oracle based tests passed with the current implementation. The problem was with the
SyscallWritePreimage
syscall handler, which if you look at the test logs for d98442c you can see the errors of the form:If you want to run them locally, you can use the one-liner
The problem is that the current write handler isn't writing to the appropriate places in the register. I came up with a solution that fixes the problem with the cost of increasing the scratch space and the number of registers. If we're looking to "pay less" for the correct implementation, we can use this as a starting point.