Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plonk-wasm #2876

Draft
wants to merge 9 commits into
base: dw/merge-back-develop-in-master
Choose a base branch
from
Draft

Conversation

martyall
Copy link
Contributor

Move over plonk-wasm package from mina

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3559 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (c54f985) to head (07ee3a7).

Files with missing lines Patch % Lines
plonk-wasm/src/plonk_verifier_index.rs 0.00% 673 Missing ⚠️
plonk-wasm/src/plonk_proof.rs 0.00% 518 Missing ⚠️
plonk-wasm/src/srs.rs 0.00% 246 Missing ⚠️
plonk-wasm/src/pasta_fp_plonk_index.rs 0.00% 201 Missing ⚠️
plonk-wasm/src/wasm_ocaml_serde/ser.rs 0.00% 200 Missing ⚠️
plonk-wasm/src/wasm_ocaml_serde/de.rs 0.00% 195 Missing ⚠️
plonk-wasm/src/pasta_fq_plonk_index.rs 0.00% 178 Missing ⚠️
plonk-wasm/src/arkworks/pasta_fp.rs 0.00% 166 Missing ⚠️
plonk-wasm/src/arkworks/pasta_fq.rs 0.00% 166 Missing ⚠️
plonk-wasm/src/oracles.rs 0.00% 142 Missing ⚠️
... and 13 more
Additional details and impacted files
@@                         Coverage Diff                         @@
##           dw/merge-back-develop-in-master    #2876      +/-   ##
===================================================================
- Coverage                            72.22%   68.90%   -3.32%     
===================================================================
  Files                                  255      278      +23     
  Lines                                60449    64008    +3559     
===================================================================
+ Hits                                 43658    44106     +448     
- Misses                               16791    19902    +3111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall
Copy link
Contributor Author

martyall commented Dec 15, 2024

@dannywillems tests are passing but lint check is failing, e.g.

error: `extern` fn uses type `ark_ff::Fp<ark_ff::MontBackend<mina_curves::pasta::fields::FqConfig, 4>, 4>`, which is not FFI-safe
   --> plonk-wasm/src/projective.rs:147:9
    |
147 |         WasmPastaFp,
    |         ^^^^^^^^^^^ not FFI-safe
    |
    = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct
    = note: this struct has unspecified layout

Since there was no clippy check in mina, this could have been present for quite a while. The WasmPastFp type does have a #[repr(C)] attribute, but it wraps a newtype in arkworks that has no such instance. Clearly things are working anyway, what do you think we should do?

@dannywillems dannywillems force-pushed the dw/merge-back-develop-in-master branch 3 times, most recently from 2326314 to 0c64141 Compare January 12, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant