Upstream openmina changes #2750
Conversation
| @@ -93,6 +93,13 @@ impl Keypair { | |||
| pub fn to_hex(&self) -> String { | |||
| hex::encode(self.to_bytes()) | |||
| } | |||
|
|
|||
| /// Performs scalar multiplication with the secret key | |||
There was a problem hiding this comment.
Opinion: I would inline it in the OpenMina codebase, see #2755. Curious to see the other team members opinions.
| @@ -19,6 +19,16 @@ impl Signature { | |||
| pub fn new(rx: BaseField, s: ScalarField) -> Self { | |||
| Self { rx, s } | |||
| } | |||
|
|
|||
| /// Dummy signature | |||
| @@ -232,6 +232,12 @@ pub struct CompressedPubKey { | |||
| pub is_odd: bool, | |||
| } | |||
|
|
|||
| impl fmt::Debug for CompressedPubKey { | |||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | |||
| f.write_fmt(format_args!("{}", self.into_address())) | |||
kimchi/src/proof.rs
Outdated
| /// Mimic OCaml `point[0]` | ||
| /// | ||
| /// Short for `first` | ||
| pub fn fst(&self) -> Evals { |
There was a problem hiding this comment.
We should change the Caml side instead. It is pretty ugly if we do point[0] in OCaml.
There was a problem hiding this comment.
See openmina/openmina#890. I'll keep in mind to change in Pickles.
| @@ -207,7 +207,7 @@ where | |||
| }; | |||
|
|
|||
| // TODO: Switch to commit_evaluations for all index polys | |||
| VerifierIndex { | |||
| Arc::new(VerifierIndex { | |||
There was a problem hiding this comment.
Wondering if it requires changes in wasm stubs. I'll have a look later.
There was a problem hiding this comment.
@dannywillems Did you have time to look into this ?
There was a problem hiding this comment.
@volhovm is working on merging develop into master and use master in MinaProtocol/Mina. We should have an idea if it breaks when this is done.
There was a problem hiding this comment.
Work happening here. I'll come back on this PR when !2868 is merged (with o1js/mina related PR).
sebastiencs
force-pushed
the
upstream-openmina
branch
from
dde0cdd to
e132e54
Compare
|
Just removed dde0cdd from the PR.
|
@dannywillems This contains the diffs we use for
openminaMerging this will allow us to depend directly on your
masterbranch, without having to maintain our own forkcc @adonagy @binier , some commits belongs to you