Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] CI refactoring, test coverage data gathering (disabled for CI) and reports generation. #2570

Merged
merged 46 commits into from
Sep 23, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Sep 18, 2024

Future tasks:

shimkiv and others added 30 commits September 18, 2024 17:27
… with coverage as part of regular checks, remove flag from coverage uploading to see if it helps with diff processing.
Released earlier this year in July. No big changes.
Only bumping up to stay up-to-date.
… and make Nightly builds on demand with the coverage report attached to the job execution results rather than upload it to the Codecov to not mess the diff checks.
…heavy, everything else will be executed during the Nightly runs.
We do use some unstable feature, like:

```
Warning: can't set `indent_style = Block`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
```
@shimkiv shimkiv self-assigned this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@66eaad5). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2570   +/-   ##
==========================================
  Coverage           ?   74.42%           
==========================================
  Files              ?      121           
  Lines              ?    26626           
  Branches           ?        0           
==========================================
  Hits               ?    19817           
  Misses             ?     6809           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shimkiv shimkiv marked this pull request as ready for review September 19, 2024 05:36
@shimkiv shimkiv changed the title [Develop] CI refactoring, test coverage data gathering and reports generation. [Develop] CI refactoring, test coverage data gathering (disabled for CI) and reports generation. Sep 19, 2024
Copy link
Member

@volhovm volhovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you :)

@volhovm volhovm merged commit 6d7d743 into develop Sep 23, 2024
6 checks passed
@volhovm volhovm deleted the chore/ci-refactoring-develop branch September 23, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants