-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Develop] CI refactoring, test coverage data gathering (disabled for CI) and reports generation. #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with coverage as part of regular checks, remove flag from coverage uploading to see if it helps with diff processing.
Released earlier this year in July. No big changes. Only bumping up to stay up-to-date.
… and make Nightly builds on demand with the coverage report attached to the job execution results rather than upload it to the Codecov to not mess the diff checks.
…heavy, everything else will be executed during the Nightly runs.
We do use some unstable feature, like: ``` Warning: can't set `indent_style = Block`, unstable features are only available in nightly channel. Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel. ```
… checks for Codecov.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2570 +/- ##
==========================================
Coverage ? 74.42%
==========================================
Files ? 121
Lines ? 26626
Branches ? 0
==========================================
Hits ? 19817
Misses ? 6809
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dannywillems
approved these changes
Sep 19, 2024
shimkiv
changed the title
[Develop] CI refactoring, test coverage data gathering and reports generation.
[Develop] CI refactoring, test coverage data gathering (disabled for CI) and reports generation.
Sep 19, 2024
This was referenced Sep 19, 2024
volhovm
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
develop
.master
.Future tasks:
develop
. #2582