-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect lookup PR1263 [do not merge] #1489
Conversation
56c9985
to
779d4f6
Compare
@dannywillems I confirm that the For the context, the scenario could be alternatively captured by adding such a row into https://github.com/o1-labs/proof-systems/pull/1454/files#diff-30d4661dcab0b5e55e4bb6f27ea2c313bded3d2fc088df9d16f6d0fdde981cc1R603 (by either adding zero into indices, or into values, but not into both). |
Please split in small PRs. Independent changes must go in different PRs and commits. |
This reverts commit cd04b91.
…kups-pr-chunk1 Resurrecting lookup PR: Fix lookup has_zero_entry bug
779d4f6
to
f770876
Compare
Important! Note that this commit /still/ has the bug mina#14657. It will be fixed in the next commit explicitly, so that the bug can be hunted down.
f770876
to
07222ac
Compare
Most chunks of these were merged independently. What was not resurrected is creating a private |
This resurrects #1263 which was reverted in #1378 due to the bug that is to be understood within this PR.
Important! Note that the first commit /still/ has the bug MinaProtocol/mina#14657. It will be fixed in the following commits explicitly, so that the bug can be hunted down.
Plan before this can be re-merged:
zero_row_zero_id
still makes sensemina