Add other accessors necessary for zkVM memory #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querolita
approved these changes
Dec 5, 2023
| @@ -47,7 +47,7 @@ pub struct Env<Fp> { | |||
| pub instruction_parts: InstructionParts<u32>, | |||
| pub instruction_counter: usize, | |||
| pub memory: Vec<(u32, Vec<u8>)>, | |||
There was a problem hiding this comment.
Wasn't the content of the memory and registers of type Variable? Or does this casting only happen inside the interpreter?
There was a problem hiding this comment.
The Variable type is only in the interpreter, yea.
dannywillems
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #1382, adding counterpart operations for
These primitives are essential for the correct operation of RAMLookup, ensuring that reads are 'temporal' (i.e. you can't read a value in the past that you wrote in the future).