Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-process pipes, ensure that they aren't free'd #1339

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

mrmr1993
Copy link
Member

This PR builds upon #1338. This does several things:

  • splits the reading and writing ends of pipes between the client (VM interpreter) and server processes
  • keeps around references to all of the pipes, so that they don't get drop-ed and cause a reference to a freed file descriptor
  • passes the correct ends of pipes to the processes, so that the corresponding read/write calls don't immediately fail.

This was tested by sending a dummy hint to the server process and logging a message to show it being received. Also, this now does not immediately crash.

@rbonichon rbonichon merged commit 5628f83 into rb/file-descriptors Nov 27, 2023
4 checks passed
@rbonichon rbonichon deleted the feature/file-pipes branch November 27, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants