-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single-row Optimizations on top of KeccakRound gate #1301
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querolita
force-pushed
the
zkvm/keccak/tests
branch
2 times, most recently
from
November 1, 2023 12:52
3ccebf0
to
5ecf0ad
Compare
querolita
force-pushed
the
zkvm/keccak/optimized
branch
from
November 1, 2023 15:07
d82f902
to
72ba91e
Compare
querolita
changed the base branch from
zkvm/keccak/tests
to
zkvm/keccak/framework
November 1, 2023 15:08
querolita
force-pushed
the
zkvm/keccak/optimized
branch
from
November 1, 2023 16:26
96ad811
to
ff9405b
Compare
This was referenced Dec 11, 2023
Making it a draft for now. The gate changes are in #1542. Will reopen when the proof system is modified to be compatible with these branches. |
Closing because the constraints and witness have already been merged, and we probably won't be integrating kimchi's proof system with these for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These optimizations still keep the
KeccakRound
gate in one single row. Other optimizations will build on top of this one to split across rows to create narrower chips. Here, by "Old" I mean the design shown in the RFC.Old column count: 2344
New column count: 1965
Old constraint count: 754
New constraint count: 389
Old lookup count: 1760
New lookup count: 1620
Old prover time: 23s x 1 hash | 1871s x 1000 hash
New prover time: 19s x 1 hash | 1691s x 1000 hash
Old setup time: 57s x 1 hash | 517s x 1000 hash
New setup time: 57s x 1 hash | 479s x 1000 hash
Old verifier time: 6516ms x 1 hash | 6797ms x 1000 hash
New verifier time: 5600ms x 1 hash | 6021ms x 1000 hash