Layout for the Keccak witness #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querolita
force-pushed
the
zkvm/keccak/circuit
branch
from
9acd6fb to
65f27ae
Compare
querolita
force-pushed
the
zkvm/keccak/layout
branch
from
c3ce047 to
cbab79a
Compare
5 tasks
querolita
force-pushed
the
zkvm/keccak/circuit
branch
from
5c42ebd to
1e23d22
Compare
querolita
changed the base branch from
zkvm/keccak/circuit
to
zkvm/keccak/indexcell
querolita
force-pushed
the
zkvm/keccak/layout
branch
from
5823a90 to
fdf2849
Compare
querolita
changed the title
WitnessCell to support vector layout for the Keccak witness
dannywillems
approved these changes
Nov 3, 2023
@dannywillems I just fixed the notation in the RFC so the names match 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1210 #1211 #1212 #1213