Skip to content

Commit

Permalink
Merge pull request #2923 from calciumbe/fix/typo
Browse files Browse the repository at this point in the history
Fix typos
  • Loading branch information
dannywillems authored Jan 6, 2025
2 parents 22f76e5 + d7cb8ff commit 2d4480d
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion folding/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ impl<'a, CF: FoldingConfig> FoldingScheme<'a, CF> {
let error_evals = error.map(|e| Evaluations::from_vec_and_domain(e, self.domain));

// Committing to the cross terms
// Default blinder for commiting to the cross terms
// Default blinder for committing to the cross terms
let blinders = PolyComm::new(vec![ScalarField::<CF>::one()]);
let error_commitments = error_evals
.iter()
Expand Down
2 changes: 1 addition & 1 deletion folding/tests/test_folding_with_quadriticization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ impl FoldingEnv<Fp, TestInstance, TestWitness, TestColumn, TestChallenge, Dynami
}

// this is exclusively for dynamic selectors aiming to make use of optimization
// as clasic static selectors will be handle as normal structure columns in col()
// as classic static selectors will be handle as normal structure columns in col()
// the implementation of this if the same as col(), it is just separated as they
// have different types to resolve
fn selector(&self, s: &DynamicSelector, side: Side) -> &[Fp] {
Expand Down
2 changes: 1 addition & 1 deletion folding/tests/test_quadraticization.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//! quadraticization test, check that diferent cases result in the expected number of columns
//! quadraticization test, check that different cases result in the expected number of columns
//! being added
use ark_poly::Radix2EvaluationDomain;
use folding::{
Expand Down
2 changes: 1 addition & 1 deletion ivc/tests/simple.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ pub fn heavy_test_simple_add() {
.map(|x| FoldingCompatibleExpr::from(x.clone()))
.collect();

// IVC column expression should be shifted to the right to accomodate
// IVC column expression should be shifted to the right to accommodate
// app witness.
let ivc_mapper = &(|Variable { col, row }| {
let rel_offset: usize = AdditionColumn::COUNT;
Expand Down
2 changes: 1 addition & 1 deletion kimchi/src/snarky/constraint_system.rs
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ impl<Field: PrimeField> SnarkyConstraintSystem<Field> {
let public_input_size = self.public_input_size.unwrap();
let pub_selectors: Vec<_> = vec![
Field::one(),
// TODO: unecessary
// TODO: unnecessary
Field::zero(),
Field::zero(),
Field::zero(),
Expand Down
2 changes: 1 addition & 1 deletion kimchi/src/snarky/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ pub type SnarkyRuntimeResult<T> = std::result::Result<T, Box<SnarkyRuntimeError>
pub type SnarkyCompileResult<T> = std::result::Result<T, SnarkyCompilationError>;

#[derive(Debug, Error)]
#[error("an error ocurred in snarky")]
#[error("an error occurred in snarky")]
pub struct RealSnarkyError {
/// The actual error.
pub source: SnarkyError,
Expand Down
2 changes: 1 addition & 1 deletion msm/src/fec/interpreter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ pub fn constrain_ec_addition<
.enumerate()
{
if i % 6 == 5 {
// This should be a diferent range check depending on which big-limb we're processing?
// This should be a different range check depending on which big-limb we're processing?
// So instead of one type of lookup we will have 5 different ones?
env.lookup(LookupTable::RangeCheck9Abs, vec![x.clone()]);
} else {
Expand Down
2 changes: 1 addition & 1 deletion msm/src/logup.rs
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ pub mod prover {
/// Create an environment for the prover to create a proof for the Logup protocol.
/// The protocol does suppose that the individual lookup terms are
/// committed as part of the columns.
/// Therefore, the protocol only focus on commiting to the "grand
/// Therefore, the protocol only focus on committing to the "grand
/// product sum" and the "row-accumulated" values.
pub fn create<
OpeningProof: OpenProof<G>,
Expand Down
4 changes: 2 additions & 2 deletions msm/src/test/test_circuit/interpreter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -162,15 +162,15 @@ pub fn constrain_test_fixed_sel_degree_7_with_constants<
env: &mut Env,
) {
let a0 = Env::read_column(env, TestColumn::A(0));
let fourty_two = Env::constant(F::from(42u32));
let forty_two = Env::constant(F::from(42u32));
let three = Env::constant(F::from(3u32));
let b0 = Env::read_column(env, TestColumn::B(0));
let fixed_e = Env::read_column(env, TestColumn::FixedSel1);
let a0_2 = a0.clone() * a0.clone();
let a0_4 = a0_2.clone() * a0_2.clone();
let a0_6 = a0_4.clone() * a0_2.clone();
let a0_7 = a0_6.clone() * a0.clone();
let equation = three * a0_7.clone() + fourty_two * b0.clone() - fixed_e;
let equation = three * a0_7.clone() + forty_two * b0.clone() - fixed_e;
env.assert_zero(equation.clone());
}

Expand Down
2 changes: 1 addition & 1 deletion poly-commitment/src/ipa.rs
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ where

let coeffs: Vec<_> = plnm.iter().map(|c| c.into_bigint()).collect();

// chunk while commiting
// chunk while committing
let mut chunks = vec![];
if is_zero {
chunks.push(G::zero());
Expand Down
2 changes: 1 addition & 1 deletion poly-commitment/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ impl<'a, F: Field> ScaledChunkedPolynomial<F, &'a [F]> {

/// Combine the polynomials using a scalar (`polyscale`), creating a single
/// unified polynomial to open. This function also accepts polynomials in
/// evaluations form. In this case it applies an IFFT, and, if necessarry,
/// evaluations form. In this case it applies an IFFT, and, if necessary,
/// applies chunking to it (ie. split it in multiple polynomials of
/// degree less than the SRS size).
///
Expand Down

0 comments on commit 2d4480d

Please sign in to comment.