Fix and finite field operations in bindings/crypto module #1765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🔗 bindings PR: o1-labs/o1js-bindings#287
This pull request addresses issues and has a slight optimization change in the finite field operations.
The following tasks were accomplished:
isSquare
andsqrt
methods to ensure input is taken modulo pequal
method to avoid unnecessary modulo operationsAdditional Information
These changes ensure that the finite field operations work correctly for all input values and improve performance by reducing unnecessary computations. The optimization in the
equal
method is particularly beneficial for frequently used operations.It also addresses the issue found in the audit where with this code: