Skip to content

Commit

Permalink
updating changelog and adding comment to unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
Test committed Oct 21, 2024
1 parent fa3e1ef commit 7958bda
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Fixes

- Performance regression when compiling recursive circuits is fixed https://github.com/o1-labs/o1js/pull/1874
- Decouple offchain state instances from their definitions https://github.com/o1-labs/o1js/pull/1834

## [1.9.0](https://github.com/o1-labs/o1js/compare/450943...f15293a69) - 2024-10-15
Expand Down
2 changes: 1 addition & 1 deletion src/bindings
9 changes: 9 additions & 0 deletions src/lib/proof-system/cached-lagrange-basis.unit-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ describe('Compiling a program with a cache', () => {
await fs.rm(__cacheDirname, { recursive: true });
});

/**
* This test is a regression test for https://github.com/o1-labs/o1js/issues/1869
* It ensures that the lagrange basis cache is accessed properly. If the file system cache is not
* read during compile, that means that the lagrange basis was returned from WASM on the first attempt.
*
* This is not necessarily a problem. If the WASM code is updated such that we expect the LB to be
* returned on the first try, and we explicitly skip the file system cache, then this test can be
* safely removed. Otherwise, a failure here probably indicates a performance regression.
*/
it('should attempt to read lagrange basis from the cache during compile', async () => {
cache.lagrangeBasisReadCount = 0;
await exampleProgram.compile({ cache });
Expand Down
2 changes: 1 addition & 1 deletion src/mina
Submodule mina updated 149 files

0 comments on commit 7958bda

Please sign in to comment.