Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunking #312

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Chunking #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c99c957
enable chunking
Trivo25 Sep 12, 2024
e6d2639
Merge branch 'main' into chunking-mvp-bug
Trivo25 Sep 18, 2024
2e8e834
Merge branch 'main' into chunking-mvp-bug
Trivo25 Oct 11, 2024
e0d5173
Merge branch 'main' into chunking-mvp-bug
querolita Nov 12, 2024
38d0036
Merge branch 'main' into querolita/chunking-mvp-bug
querolita Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ocaml/lib/pickles_bindings.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,8 @@ let pickles_compile (choices : pickles_rule_js array)
< publicInputSize : int Js.prop
; publicOutputSize : int Js.prop
; storable : Cache.js_storable Js.optdef_prop
; overrideWrapDomain : int Js.optdef_prop >
; overrideWrapDomain : int Js.optdef_prop
; chunks : int Js.prop >
Js.t ) =
(* translate number of branches and recursively verified proofs from JS *)
let branches = Array.length choices in
Expand All @@ -597,6 +598,7 @@ let pickles_compile (choices : pickles_rule_js array)
(* translate method circuits from JS *)
let public_input_size = config##.publicInputSize in
let public_output_size = config##.publicOutputSize in
let num_chunks = config##.chunks in
let override_wrap_domain =
Js.Optdef.to_option config##.overrideWrapDomain
|> Option.map ~f:Pickles_base.Proofs_verified.of_int_exn
Expand All @@ -620,7 +622,7 @@ let pickles_compile (choices : pickles_rule_js array)
(Input_and_output
( public_input_typ public_input_size
, public_input_typ public_output_size ) )
~auxiliary_typ:Typ.unit
~auxiliary_typ:Typ.unit ~num_chunks
~branches:(module Branches)
~max_proofs_verified:(module Max_proofs_verified)
~name ?storables ?cache
Expand Down
3 changes: 2 additions & 1 deletion ocaml/lib/pickles_bindings.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ val pickles :
-> < publicInputSize : int Js.prop
; publicOutputSize : int Js.prop
; storable : Cache.js_storable Js.optdef_prop
; overrideWrapDomain : int Js.optdef_prop >
; overrideWrapDomain : int Js.optdef_prop
; chunks : int Js.prop >
Js.t
-> < getVerificationKey :
( unit
Expand Down
Loading