fix(npm-groovy-lint): diagnostics not parsed #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error:
maybe because the stdin was too heavy, I was able to fix that with writing to a temp file.
then, I had to change the on_output to find the key of the
files
table and not assume it's"1"
anyway here's the before:
and here's the after:
One more thing. when developing a Jenkinsfile, we import a library our system doesn't recognize so base on this:
nvuillam/npm-groovy-lint#422 (comment)
we should add the flag
--no-parse
in this case.