Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm-groovy-lint): diagnostics not parsed #224

Merged
merged 12 commits into from
Dec 26, 2024

Conversation

mosheavni
Copy link
Contributor

@mosheavni mosheavni commented Dec 25, 2024

I was getting this error:

[DEBUG Wed Dec 25 11:39:06 2024] /Users/mavni/Repos/none-ls.nvim/lua/null-ls/helpers/generator_factory.lua:352: spawning command "npm-groovy-lint" at /Users/mavni/Repos/shared-libraries with args { "-o", "json", "-" }
[TRACE Wed Dec 25 11:39:06 2024] /Users/mavni/Repos/none-ls.nvim/lua/null-ls/helpers/generator_factory.lua:236: error output: Parse options error: EAGAIN: resource temporarily unavailable, read

[TRACE Wed Dec 25 11:39:06 2024] /Users/mavni/Repos/none-ls.nvim/lua/null-ls/helpers/generator_factory.lua:237: output: nil
[TRACE Wed Dec 25 11:39:06 2024] /Users/mavni/Repos/none-ls.nvim/lua/null-ls/helpers/generator_factory.lua:247: ignoring stderr due to generator options
[TRACE Wed Dec 25 11:39:06 2024] /Users/mavni/Repos/none-ls.nvim/lua/null-ls/diagnostics.lua:185: received diagnostics from source 11
[TRACE Wed Dec 25 11:39:06 2024] /Users/mavni/Repos/none-ls.nvim/lua/null-ls/diagnostics.lua:186: {}

maybe because the stdin was too heavy, I was able to fix that with writing to a temp file.
then, I had to change the on_output to find the key of the files table and not assume it's "1"

anyway here's the before:
image

and here's the after:
image

One more thing. when developing a Jenkinsfile, we import a library our system doesn't recognize so base on this:
nvuillam/npm-groovy-lint#422 (comment)
we should add the flag --no-parse in this case.

@mosheavni mosheavni marked this pull request as draft December 25, 2024 10:23
@mosheavni mosheavni marked this pull request as ready for review December 25, 2024 10:30
@mosheavni mosheavni requested a review from mochaaP December 26, 2024 11:59
@mochaaP mochaaP merged commit 43a89a4 into nvimtools:main Dec 26, 2024
3 checks passed
@mosheavni mosheavni deleted the fix/npm-groovy-lint branch December 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants