Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom highlighting with plugin RRethy/vim-illuminate #1265

Closed
wants to merge 2 commits into from

Conversation

denius
Copy link

@denius denius commented Dec 13, 2024

This is a PR for #1253, it replaces the word highlighting functions with a plugin that has more customization options.

The main reason for this PR is that the highlighting functionality in kickstart.nvim is incompatible with the use of highlighting plugins, as there is no way to disable the built-in highlighting other than commenting it out entirely.

The configuration is completely taken from the plugin page RRethy/vim-illuminate.

@iton0
Copy link
Contributor

iton0 commented Dec 13, 2024

I think introducing a plugin for cursor word highlighting doesn't fit in with kickstart. However I think given the incompatibility issue, it would be beneficial to update the comments for this code. This way new users can be made aware and either keep the default or comment out and add whichever highlighting plugins in their own configs.

@feoh
Copy link
Collaborator

feoh commented Dec 15, 2024

@denius Thank you for your PR. I know I suggested it, but I think @iton0 is right and the way to go here is to just suggest that users have the option to use this in comments.

@denius
Copy link
Author

denius commented Dec 15, 2024

I realized that it is better to do without an extra plugin if possible.

@denius denius closed this Dec 15, 2024
@denius denius deleted the pr-highlight-word branch December 15, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants