Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : fish cannot execute this command #1203

Closed
wants to merge 1 commit into from

Conversation

marsevilspirit
Copy link

git clone https://github.com/nvim-lua/kickstart.nvim.git "${XDG_CONFIG_HOME:-$HOME/.config}"/nvim

This command cannot be executed in fish. It is recommended to modify it to the following form:

bash -c 'git clone https://github.com/nvim-lua/kickstart.nvim.git "${XDG_CONFIG_HOME:-$HOME/.config}/nvim"'

@feoh
Copy link
Collaborator

feoh commented Oct 30, 2024

I don't love this approach.

Is there a fish equivalent to the $XDG_HOME variable expansion that we could provide as an alternative "If Using fish shell" instruction in the README?

@feoh
Copy link
Collaborator

feoh commented Oct 30, 2024

The more I think about this, the more I think this isn't actually appropriate fir kickstart.

What about Nushell? Elvish? tcsh? csh?

Shells are legion. bash/zsh represent a reasonable mainline target to support.

Please, folks in the community please reopen if you feel strongly otherwise.

@feoh feoh closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants