Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally add statuscol.nvim #1196

Closed
wants to merge 2 commits into from
Closed

Optionally add statuscol.nvim #1196

wants to merge 2 commits into from

Conversation

glmlm
Copy link
Contributor

@glmlm glmlm commented Oct 18, 2024

The visibility of the default statuscolumn is not very flattering; only one of diagnostics, gitsigns, and breakpoints can be displayed, and foldcolumn displays a lot of unnecessary symbols.
Therefore, I propose to provide optional settings with a plugin that improve its appearance; statuscol.nvim.

Note: Subsequent PR was moved to #1198 I also considered it really annoying to set the foldings every time I open a file, so I have added a plugin that set them automatically like VSCode; nvim-ufo.

I understand that adding them is controversial, especially from a "kickstart" perspective.
Personally, I think it is worth adding them if only as an option, as I believe it would be inconvenient for VSCode users to be without them when they first touch Neovim.

@iton0
Copy link
Contributor

iton0 commented Oct 18, 2024

To avoid overwhelming new users, it's important to keep the setup simple and compact. While additional plugins can enhance functionality, they may complicate the initial experience. If we add these plugins, we should also consider the needs of users switching from other IDEs. While these features could be useful, I believe it's better to keep them out of the repository and let users discover them independently.

@glmlm
Copy link
Contributor Author

glmlm commented Oct 18, 2024

@iton0

it's important to keep the setup simple and compact

Obviously, I understand the importance of keeping it to a minimum. Before adding a plug-in, even if it is an optional one, its necessity should be carefully considered.
Based on that line of thinking, it might have been better to split this pull request into at least two parts. I personally think it would be more user-friendly to have automatic folding, but there might be quite a few people who don't need it.
However, I think there is a little more room for further consideration on statuscol.nvim, in my opinion. It is sort of counter-intuitive that only one of the diagnostic and gitsigns symbols are displayed, even though they are configured to be displayed in init.lua.

I would appreciate your candid feedback.

@iton0
Copy link
Contributor

iton0 commented Oct 18, 2024

Based on that line of thinking, it might have been better to split this pull request into at least two parts.

I agree that splitting the PR may be a better approach.

It is sort of counter-intuitive that only one of the diagnostic and gitsigns symbols are displayed,

That is true. I would read the docs on the statuscolumn because you may be able to configure it in such a way that a plugin is not needed. For example with the issue that you pointed out, you can increase the width of the signcolumn to display more signs.

@glmlm
Copy link
Contributor Author

glmlm commented Oct 19, 2024

may be able to configure it in such a way that a plugin is not needed

It would be appreciated if this problem could be solved without using a plugin, but it appears that it is not that simple.
vim.opt.signcolumn = 'yes:2' simply increases the upper limit of the display, and if there are more than two diagnostics, the symbol of gitsigns will no longer be displayed.
There is also a problem with the method of displaying foldings neatly without a plugin. It is mentioned here, but I don't think it is a smart way to go about it because it is to increase the display limit as above.

@glmlm glmlm changed the title Optionally add statuscol.nvim and nvim-ufo Optionally add statuscol.nvim Oct 19, 2024
@rgruyters
Copy link
Contributor

I agree with @iton0, this may overwhelm new users and I think this plugin is more a personal taste to use than for everybody. I advise to keep kickstart.nvim as simple as possible, with a minimum of plugins.

oriori1703 added a commit to oriori1703/kickstart-modular.nvim that referenced this pull request Oct 29, 2024
@feoh
Copy link
Collaborator

feoh commented Oct 30, 2024

Hi. Thank you for your contribution, feel free to make this change in your own fork, but as the community has pointed out this change probably isn't appropriate for kickstart.

Closing.

@feoh feoh closed this Oct 30, 2024
oriori1703 added a commit to oriori1703/kickstart-modular.nvim that referenced this pull request Nov 4, 2024
@glmlm glmlm deleted the statuscol branch November 14, 2024 12:16
oriori1703 added a commit to oriori1703/kickstart-modular.nvim that referenced this pull request Nov 27, 2024
oriori1703 added a commit to oriori1703/kickstart-modular.nvim that referenced this pull request Dec 21, 2024
oriori1703 added a commit to oriori1703/kickstart-modular.nvim that referenced this pull request Jan 2, 2025
oriori1703 added a commit to oriori1703/kickstart-modular.nvim that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants