Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): skip installation of already installed modules #654

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

DamianGlowala
Copy link
Member

πŸ”— Linked issue

resolves #229

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This better communicates which modules are already installed and skips their installation.

@DamianGlowala DamianGlowala self-assigned this Jan 8, 2025
Copy link

pkg-pr-new bot commented Jan 8, 2025

Open in Stackblitz β€’ nuxt-cli-playground

npm i https://pkg.pr.new/nuxi@654

commit: 286767a

Copy link

github-actions bot commented Jan 8, 2025

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
54 5.67 MB β†’ 5.67 MB (+145 B) +0.00%
Changeset
File Ξ” Size
src/commands/module/add.ts πŸ“ˆ +1.3 kB (+14.81%) 8.76 kB β†’ 10.05 kB
src/commands/add.ts πŸ“ˆ +99 B (+4.99%) 1.94 kB β†’ 2.04 kB
package.json πŸ“‰ -22 B (-0.83%) 2.59 kB β†’ 2.57 kB
src/main.ts πŸ“‰ -23 B (-2.01%) 1.12 kB β†’ 1.09 kB
src/commands/init.ts πŸ“‰ -1.02 kB (-20.21%) 5.04 kB β†’ 4.02 kB
src/utils/templates/index.ts πŸ“‰ -194 B (-27.79%) 698 B β†’ 504 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/nuxi.BVSKcfmX.mjs 0 B β†’ 78.61 kB (+78.61 kB) -
shared/nuxi.DzNwkU8w.mjs 0 B β†’ 17.69 kB (+17.69 kB) -
shared/nuxi.DbLwAM-O.mjs 0 B β†’ 1.11 kB (+1.11 kB) -
shared/nuxi.CXkb2GZv.mjs 0 B β†’ 804 B (+804 B) -
shared/nuxi.20htGcgr.mjs 0 B β†’ 294 B (+294 B) -

Removed

Asset File Size % Changed
shared/nuxi.DkyhQQf1.mjs 78.65 kB β†’ 0 B (-78.65 kB) -100%
shared/nuxi.CtYpQNJa.mjs 17.69 kB β†’ 0 B (-17.69 kB) -100%
shared/nuxi.0ShblKVI.mjs 1.11 kB β†’ 0 B (-1.11 kB) -100%
shared/nuxi.VuLgwPtj.mjs 804 B β†’ 0 B (-804 B) -100%
shared/nuxi.DY-sU5CF.mjs 294 B β†’ 0 B (-294 B) -100%

Bigger

Asset File Size % Changed
chunks/add2.mjs 10.6 kB β†’ 11.89 kB (+1.3 kB) +12.24%

Smaller

Asset File Size % Changed
chunks/init.mjs 805.3 kB β†’ 804.28 kB (-1.02 kB) -0.13%
chunks/add.mjs 6.83 kB β†’ 6.74 kB (-95 B) -1.36%

Unchanged

Asset File Size % Changed
index.mjs 188 B 0%
chunks/prompt.mjs 46.07 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.75 kB 0%
chunks/dev.mjs 9.58 kB 0%
chunks/devtools.mjs 736 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 2.81 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.58 kB 0%
chunks/upgrade.mjs 5.69 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.34 kB 0%
chunks/index2.mjs 909.09 kB 0%
chunks/dev2.mjs 68.95 kB 0%
chunks/index3.mjs 17.11 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.34 kB 0%
chunks/index4.mjs 1.24 kB 0%
chunks/index5.mjs 6.55 kB 0%
chunks/index6.mjs 70.29 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/search.mjs 42.99 kB 0%
chunks/index7.mjs 5.87 kB 0%
chunks/index8.mjs 882.9 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/nuxi.DdI-vRyV.mjs 1.54 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.jHNMu6i2.mjs 1.34 kB 0%
shared/nuxi.D1V6iren.mjs 20.07 kB 0%
shared/nuxi.BgpyaHY1.mjs 14.64 kB 0%
shared/nuxi.u_uB65ir.mjs 8.04 kB 0%
shared/nuxi.SEuYCQjN.mjs 2.02 MB 0%
shared/nuxi.BHLUJ6h2.mjs 5.12 kB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.BgENdoyd.mjs 1.76 kB 0%
shared/nuxi.C2bb3PPD.mjs 152.13 kB 0%
shared/nuxi.DfYkt6zx.mjs 285.08 kB 0%
shared/nuxi.ChFrgAY-.mjs 5.71 kB 0%
shared/nuxi.BZI8rqcO.mjs 6.13 kB 0%
shared/nuxi.BPuj-7ta.mjs 42.89 kB 0%

@danielroe danielroe merged commit aec485d into main Jan 9, 2025
9 checks passed
@danielroe danielroe deleted the feat/skip-installing-already-installed-modules branch January 9, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxi module add check if module already installed
2 participants