update k8s cluster list response type, add tests for pagination scenarios #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakm-ntnx
requested review from
deepakm-ntnx,
johnliu25 and
thunderboltsid
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 54.30% 54.30%
=======================================
Files 20 20
Lines 1799 1799
=======================================
Hits 977 977
Misses 822 822 ☔ View full report in Codecov by Sentry. |
thunderboltsid
force-pushed
the
update_k8s_cluster_reg_tests
branch
from
a948ef5 to
e55f2ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated K8sClusterRegistration list response type and the test since response changed due to pagination.
Added tests cases to check various scenarios of pagination, request second page, more items than page size, empty list.