Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: variable for resource names specific to Nutanix #381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkoshkin
Copy link
Contributor

What this PR does / why we need it:
This driver can be deployed along side other COSI drivers. The name objectstorage-provisioner is too generic, renamed it to the name Helm variable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Followed the README to deploy the Chart.

$ kubectl apply -f https://raw.githubusercontent.com/nutanix-cloud-native/cosi-driver-nutanix/0afb5969e236f6476b501bf3de9dd7cd96727716/project/examples/awscliapppod.yaml

$ kubectl logs awscli
Defaulted container "awscli" out of: awscli, write-aws-credentials (init), write-test-file (init)
+ aws s3 ls
2024-12-26 17:17:02 sample-bucketclass97876066-3b2e-4235-9da7-2a4310320529
++ cat /tmp/test-directory/file.txt
+ readonly BUCKET_NAME=sample-bucketclass97876066-3b2e-4235-9da7-2a4310320529
+ BUCKET_NAME=sample-bucketclass97876066-3b2e-4235-9da7-2a4310320529
++ date +%Y%m%d_%H%M%S
+ readonly FILE_NAME=20241226_171741.txt
+ FILE_NAME=20241226_171741.txt
+ aws s3 cp /tmp/test-directory/file.txt s3://sample-bucketclass97876066-3b2e-4235-9da7-2a4310320529/20241226_171741.txt
upload: ../tmp/test-directory/file.txt to s3://sample-bucketclass97876066-3b2e-4235-9da7-2a4310320529/20241226_171741.txt
+ aws s3 cp s3://sample-bucketclass97876066-3b2e-4235-9da7-2a4310320529/20241226_171741.txt -
sample-bucketclass97876066-3b2e-4235-9da7-2a4310320529

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@tuxtof tuxtof force-pushed the build-use-chart-name-for-resources branch from b0f856c to 80ffe57 Compare January 15, 2025 09:17
@tuxtof tuxtof force-pushed the build-use-chart-name-for-resources branch from 80ffe57 to 6b3bcbf Compare January 15, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant