Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T13-2] SSENISUB #110

Open
wants to merge 508 commits into
base: master
Choose a base branch
from
Open

[T13-2] SSENISUB #110

wants to merge 508 commits into from

Conversation

valensia0711
Copy link

@valensia0711 valensia0711 commented Oct 4, 2018 •
edited
Loading

@nus-se-pr-bot nus-se-pr-bot requested a review from xhsien October 4, 2018 01:30
@xhsien
Copy link

xhsien commented Oct 8, 2018

Some comments from me:

  1. Update project page.
  2. For features not yet implemented, add coming in v2.0 in user guide.

xhsien
xhsien approved these changes Oct 22, 2018
View reviewed changes
Copy link

@xhsien xhsien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add relevant diagrams (activity/class/object/sequence) in your developer guide to apply what we've learnt in class!

@DanKhoo
Copy link

DanKhoo commented Oct 22, 2018

Hi @ChrisBoo, we have added some relevant diagrams, 3.2, 3.3, 3.4, 3.8 & 3.9 of the developer guide :)

abtyx and others added 20 commits October 30, 2018 01:14
@abtyx
Merge branch 'master' into v1.2privacyCommand
e305609
@abtyx
remove unused import statements
47c9f00
@abtyx
edit PrivacyCommand to take in the new fields Feedback, Salary etc
9844f71
@abtyx
edit Phone equals method to check privacy
44e0978 
edit XmlAdaptedPerson to account for phone privacy
edit StaffPanel to show phone privacy
@abtyx
change major bug in PrivacyCommand
caffad3
@abtyx
edit equals method for Address and Email to include checking for privacy
4e7abd1
@abtyx
make private information show up as private on staff panel
54e8ad4
@abtyx
edit tests to accomodate for changes
ac9fb6b
@abtyx
add junit testing for coveralls
3aa47e5 
change staffPanel assert to check for privacy
@abtyx
fix checkstyle
b97a231
@NgeowXiuQi
Merge pull request #56 from abtyx/v1.3PrivacyInUI
7ee803c 
V1.2 + 1.3 privacy in ui
@valensia0711
Merge branch 'master' into wip/favourite
114a985
fix conflict resolve problem
b2f879e
fix conflict resolve problem
8d68119
fix tests
fabac11
AddressBookParserTest: add test for favourite command
4bf674e
@IamRENCE
Merge pull request #5 from CS2103-AY1819S1-T13-2/master
d570530 
Merge from main 1.2/1.3
@IamRENCE
RateCommandParser: Add check if rating entered fulfils regex
7d4cf47
@IamRENCE
RateCommandParser: Check for negative index
99e7ed0
@IamRENCE
FeedbackCommandParser: Add check if feedback fulfils feedback regex
ea5fc9a
valensia0711 and others added 30 commits November 12, 2018 17:14
@valensia0711
Merge pull request #133 from NgeowXiuQi/NgeowXiuQi_PPP
7f5c9c9 
Edited AboutUs to accomodate for my PPP
@NgeowXiuQi
Edited DeveloperGuide and my PPP
6cabfae
@NgeowXiuQi
Merge pull request #134 from DanKhoo/updateDocs
11b78e3 
DeveloperGuide.adoc: Add manual test cases for add, select and find-n
@DanKhoo
Update dankhoo.adoc PPP
c1732eb
@DanKhoo
Merge pull request #135 from NgeowXiuQi/NgeowXiuQi_PPP
613000e 
Edited DeveloperGuide and my PPP
@IamRENCE
Merge pull request #13 from CS2103-AY1819S1-T13-2/master
717aec1 
More updates
@IamRENCE
Merge pull request #136 from DanKhoo/updateDocs
1fb0778 
Update dankhoo.adoc PPP
@IamRENCE
Merge pull request #14 from CS2103-AY1819S1-T13-2/master
67eb2b5 
Even more updates
@IamRENCE
Update Rate Command Sequence Diagrams
edf0cf8
@IamRENCE
Update Feedback Command Sequence Diagram
b9f064a
@IamRENCE
Add Feedback Profanity Filter Sequence Diagram
13ba9db
@IamRENCE
Update DeveloperGuide with Profanity Filter Sequence Diagram
a09ba8b
@DanKhoo
Merge pull request #137 from IamRENCE/master
abf8e09 
Add Feedback Profanity Sequence Diagram
edit developer guide to include sort commands and favourite/unfavouri…
b9dff84 
…te sequence diagrams
fix typo in developer guide for feedback command
ab69192
reorder contents in command implementation
375f66a
reorder contents in use cases
0a6b008
reorder contents in manual testing guide
6206177
add manual test for favourite command
8ce5374
add manual test for unfavourite command
58a2d02
@DanKhoo
Merge pull request #138 from CS2103-AY1819S1-T13-2/documentation
532520c 
minor edits and additions to developer guide
edit PPP: valensia0711.adoc
4bb8ee3
@IamRENCE
Merge pull request #15 from CS2103-AY1819S1-T13-2/master
1e5d8d3 
Documentation updates
@IamRENCE
Fix typo in DeveloperGuide
8e16bdb
@IamRENCE
Fix typo in PPP
83385b9
@IamRENCE
Merge pull request #139 from CS2103-AY1819S1-T13-2/documentation
494eac1 
edit PPP: valensia0711.adoc
@DanKhoo
Merge pull request #140 from IamRENCE/master
9f74fec 
Fix typo in DeverloperGuide and PPP
@DanKhoo
Update README.adoc
3ea89d6
@NgeowXiuQi
Merge pull request #141 from CS2103-AY1819S1-T13-2/updateDocs
06874cd 
Update README.adoc
@DanKhoo
Update AboutUs.adoc
a38b0d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhsien xhsien xhsien approved these changes

Assignees

@xhsien xhsien

Labels
Mid-v1.1-Reviewed team.2 tutorial.T13 v1.1-Reviewed v1.2-Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@valensia0711 @xhsien @DanKhoo @nus-se-pr-bot @abtyx @NgeowXiuQi @IamRENCE