Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Loggers use late bound TraceLevel and Writer. #1588

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Ensure Loggers use late bound TraceLevel and Writer. #1588

merged 1 commit into from
Jan 2, 2025

Conversation

manfred-brands
Copy link
Member

@manfred-brands manfred-brands commented Jan 2, 2025 •
edited
Loading

Fixes #1586

@manfred-brands manfred-brands mentioned this pull request Jan 2, 2025
Merged
CharliePoole
CharliePoole approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@CharliePoole CharliePoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's a pretty clever fix!

I think the compiler will handle this pretty efficiently, but if not we can deal with the problem then.

@CharliePoole CharliePoole merged commit 9676392 into version4 Jan 2, 2025
4 checks passed
@CharliePoole CharliePoole deleted the Loggers branch January 2, 2025 03:55
@CharliePoole
Copy link
Member

I see you were caught by the default branch merge. It still happens to me as well. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharliePoole CharliePoole CharliePoole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manfred-brands @CharliePoole