-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issue #69 - Corrected typo in About Page #72
Fixed Issue #69 - Corrected typo in About Page #72
Conversation
Akhil-Jasson
commented
Dec 15, 2024
- Replaced the phrase "made need to be made" to "may need ..." in the 01_about page
- Replaced the phrase "made need to be made" to "may need ..." in the 01_about page
…ments when switching versions)
@Akhil-Jasson please respond to my comment. I don't see why we need to add the oryx file. |
@reshamas approved the typo but when I try to build with Python 3.9 as the patch uses in the yaml file, I get an error (see below). I recommend you remove the yml changes and the additionaly oryx file and then it can be merges easily. -- Output Path: /Users/aterrel/Dev/numfocus/DISCOVER-Cookbook/DISCOVER/_build/html [0/532] Extension error: The above exception was the direct cause of the following exception: Traceback (most recent call last): The above exception was the direct cause of the following exception: Traceback (most recent call last):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not necessary.
The typo has been corrected by another PR.
It adds an additional uncessary file (oryx).
And if we are going to update the Python version (which is probably a good idea) we should really updated it to 3.13 not 3.9 which is going to be EOL soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a local thing? Seems not to be needed for the Repo.
Hi @aterrel, Thank you for your feedback! I understand now that the typo has already been addressed in another PR. I also see your point regarding the unnecessary addition of the Oryx file and the recommendation to update Python to version 3.13 instead of 3.9. Given this, it seems that this PR is no longer required. I’ll go ahead and close it to avoid any confusion. Please let me know if there are any other areas where I can contribute—I’d love to help out! |
Give a look to #74 Get Python 3.13 running, make sure the scripts and the instructions work and put it in one PR. Having PRs do more than one thing makes them harder to accept. |
Thank you, I sincerely appreciate your guidance. I’ll review #74 and proceed accordingly. |