Fix multiple checkbox errors on sample form

numerique-gouv · Sep 17, 2024 · e787cb5 · e787cb5
1 parent c976696
commit e787cb5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/dsfr/templates/dsfr/form_field_snippets/checkboxselectmultiple_snippet.html b/dsfr/templates/dsfr/form_field_snippets/checkboxselectmultiple_snippet.html
@@ -22,15 +22,10 @@
         {{ field|dsfr_input_class_attr|attr:"type:checkbox" }}
       {% endif %}
       {% if field.errors %}
-        <div id="{{ field.auto_id }}-desc-error" class="fr-error-text">
+        <div id="{{ field.auto_id }}-desc-error">
           {{ field.errors }}
         </div>
       {% endif %}
     </div>
   </div>
-  {% if field.errors %}
-    <div id="{{ field.auto_id }}-messages">
-      {{ field.errors }}
-    </div>
-  {% endif %}
 </fieldset>
diff --git a/example_app/forms.py b/example_app/forms.py
@@ -82,7 +82,7 @@ class ExampleForm(DsfrBaseForm):
         widget=forms.RadioSelect,
     )
 
-    sample_checkbox = forms.ChoiceField(
+    sample_checkbox = forms.MultipleChoiceField(
         label="Cases à cocher",
         required=False,
         choices=[
@@ -124,7 +124,7 @@ def clean_sample_radio(self):
     def clean_sample_checkbox(self):
         sample_checkbox = self.cleaned_data["sample_checkbox"]
 
-        if sample_checkbox == ["2"]:
+        if "3" in sample_checkbox:
             raise forms.ValidationError("Le troisième choix est interdit")
 
         return sample_checkbox