-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GitHub action to upload API documentation to a webpage #137
Conversation
Integration tests fail due to this line in #if NABO_VERSION_INT < 10007
#error "You need libnabo version 1.0.7 or greater"
#endif I think keeping version numbers in header file is a bad practice and that's why this PR contains removal of NABO_VERSION_INT and NABO_VERSION from nabo.h . Dependency version check can and should happen in relevant requirement and CMakeList files. @RedLeader962 I suggest we merge this PR and remove the mentioned lines from |
Here's a related PR: norlab-ulaval/libpointmatcher#567 |
Finally, I kept the NABO_VERSION_INT and NABO_VERSION in |
Description
Summary:
Changes and type of changes (quick overview):
Add a GitHub action to upload API documentation to a webpage.
The webpage is already live on https://norlab-ulaval.github.io/libnabo/ and will be updated automatically on merge to master.