forked from matrix-org/matrix-widget-api
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extend url template variables with device_id
I mentioned the need for this parameter in the related [MSC 3891 ](matrix-org/matrix-spec-proposals#3819) which implements to device messages. They are relying on the device id to be available, but there is currently no way to access a device id from within a widget (Element Call does this but is cheating :P). Therefore [I propose to include the device id in the available parameters](matrix-org/matrix-spec-proposals#3819 (comment)). Signed-off-by: Oliver Sand <[email protected]>
- Loading branch information
Showing
2 changed files
with
42 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
/* | ||
* Copyright 2023 Nordeck IT + Consulting GmbH. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { runTemplate } from "../src"; | ||
|
||
describe("runTemplate", () => { | ||
it("should replace device id template in url", () => { | ||
const url = "https://localhost/?my-query#device_id=$org.matrix.msc3819.device_id"; | ||
const replacedUrl = runTemplate( | ||
url, | ||
{ | ||
id: "widget-id", | ||
creatorUserId: '@user-id', | ||
type: 'type', | ||
url, | ||
}, | ||
{ | ||
deviceId: "my-device-id", | ||
currentUserId: '@user-id', | ||
}, | ||
); | ||
|
||
expect(replacedUrl).toBe("https://localhost/?my-query#device_id=my-device-id"); | ||
}); | ||
}); |