-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor buffer storage 2a #177
base: 12-17-refactor_buffer_storage
Are you sure you want to change the base?
refactor buffer storage 2a #177
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@@ -78,6 +80,7 @@ export class Zoom { | |||
} | |||
|
|||
attach_renderer(key: string, renderer: Renderer) { | |||
console.log("ATTACHING RENDERER") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This console.log
statement appears to be a debugging artifact and should be removed before merging to production.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Important
Refactor
src/interaction.ts
to use specificd3
types, add TypeScript error comments, and log renderer attachment.src/interaction.ts
to use more specific types fromd3-selection
,d3-timer
, andd3-zoom
.d3.Selection
withSelection
,d3.ContainerElement
withContainerElement
,d3.Timer
withTimer
,d3.ZoomBehavior
withZoomBehavior
, andd3.ZoomTransform
withZoomTransform
.@ts-expect-error
comments inzoom_to()
andzoom_to_bbox()
methods to handle TypeScript errors.attach_renderer()
method to log when a renderer is attached.This description was created by for 3e1b193. It will automatically update as commits are pushed.