Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor buffer storage 2a #177

Open
wants to merge 1 commit into
base: 12-17-refactor_buffer_storage
Choose a base branch
from

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Dec 18, 2024

Important

Refactor src/interaction.ts to use specific d3 types, add TypeScript error comments, and log renderer attachment.

  • Imports:
    • Refactor imports in src/interaction.ts to use more specific types from d3-selection, d3-timer, and d3-zoom.
    • Replace d3.Selection with Selection, d3.ContainerElement with ContainerElement, d3.Timer with Timer, d3.ZoomBehavior with ZoomBehavior, and d3.ZoomTransform with ZoomTransform.
  • Code Comments:
    • Add @ts-expect-error comments in zoom_to() and zoom_to_bbox() methods to handle TypeScript errors.
  • Logging:
    • Add console log statement in attach_renderer() method to log when a renderer is attached.

This description was created by Ellipsis for 3e1b193. It will automatically update as commits are pushed.

Copy link
Collaborator Author

bmschmidt commented Dec 18, 2024

@@ -78,6 +80,7 @@ export class Zoom {
}

attach_renderer(key: string, renderer: Renderer) {
console.log("ATTACHING RENDERER")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console.log statement appears to be a debugging artifact and should be removed before merging to production.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant