Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clarify fork inherit permission flags #56523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: clarify fork inherit permission flags #56523

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

This commit updates the documentation and includes a test to ensure that permission model flags
will be passed to the child process if fork is called

@RafaelGSS
test: clarify fork inherit permission flags
d66e9b6 
This commit updates the documentation and includes
a test to ensure that permission model flags
will be passed to the child process if `fork`
is called
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (7b472fd) to head (d66e9b6).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56523      +/-   ##
==========================================
+ Coverage   89.16%   89.17%   +0.01%     
==========================================
  Files         661      662       +1     
  Lines      191421   191583     +162     
  Branches    36845    36861      +16     
==========================================
+ Hits       170673   170851     +178     
+ Misses      13615    13611       -4     
+ Partials     7133     7121      -12

see 42 files with indirect coverage changes

@RafaelGSS RafaelGSS added test Issues and PRs related to the tests. permission Issues and PRs related to the Permission Model request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64422/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64428/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RafaelGSS @nodejs-github-bot @marco-ippolito