-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: fix symbol name and mark experimental new process methods #56517
Open
aduh95
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
aduh95:experimental-process-ref-and-unref
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
process
Issues and PRs related to the process subsystem.
labels
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56517 +/- ##
==========================================
+ Coverage 89.12% 89.17% +0.04%
==========================================
Files 662 662
Lines 191575 191585 +10
Branches 36867 36864 -3
==========================================
+ Hits 170740 170843 +103
+ Misses 13698 13607 -91
+ Partials 7137 7135 -2
|
marco-ippolito
changed the title
process: fix symbol name and mark experiemental new process methods
process: fix symbol name and mark experimental new process methods
Jan 8, 2025
aduh95
force-pushed
the
experimental-process-ref-and-unref
branch
from
January 8, 2025 18:53
cb522b9
to
8a70467
Compare
addaleax
approved these changes
Jan 8, 2025
legendecas
approved these changes
Jan 9, 2025
jasnell
reviewed
Jan 9, 2025
} | ||
|
||
// TODO(aduh95): remove support for undocumented symbol | ||
class Foo3 { | ||
refCalled = 0; | ||
unrefCalled = 0; | ||
[Symbol.for('node:ref')]() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
[Symbol.for('node:ref')]() { | |
[Symbol.for('nodejs:ref')]() { |
jasnell
approved these changes
Jan 9, 2025
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jan 9, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 9, 2025
lpinca
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
process
Issues and PRs related to the process subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods landed (and were released 😞) with two shortcomings:
node/doc/contributing/using-symbols.md
Lines 67 to 68 in cd4f4b4
Refs: #56400 (comment)