Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix jsdoc type refs to ModuleJobBase in esm/loader #56499

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

esm: fix jsdoc type refs to ModuleJobBase in esm/loader #56499

wants to merge 2 commits into from
+7 −4

Conversation

JakobJingleheimer
Copy link
Member

No description provided.

@JakobJingleheimer JakobJingleheimer added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 7, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jan 7, 2025
@JakobJingleheimer JakobJingleheimer force-pushed the esm/fix-jsdoc-getModuleJobForImport branch from c36c95d to fac3717 Compare January 7, 2025 12:16
@JakobJingleheimer JakobJingleheimer changed the title esm: fix jsdoc type for getModuleJobForImport esm: fix jsdoc type refs to ModuleJobBase in esm/loader Jan 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (52c6449) to head (fac3717).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56499      +/-   ##
==========================================
- Coverage   89.12%   89.12%   -0.01%     
==========================================
  Files         662      662              
  Lines      191555   191556       +1     
  Branches    36856    36862       +6     
==========================================
- Hits       170730   170729       -1     
+ Misses      13696    13688       -8     
- Partials     7129     7139      +10
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 97.87% <100.00%> (+<0.01%) ⬆️

... and 40 files with indirect coverage changes

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64421/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JakobJingleheimer @nodejs-github-bot @jasnell @legendecas @Ceres6