build: build v8 with -fvisibility=hidden on macOS #56275

joyeecheung · 2024-12-16T21:43:59Z

V8 should be built with -fvisibility=hidden, otherwise the resulting binary would contain unnecessary symbols. In particular, on macOS, this leads to 5000+ weak symbols resolved at runtime, leading to a startup regression.

On macOS this also reduces the binary size about ~10MB. On Linux the size reduction is around 8MB.

$ DYLD_PRINT_BINDINGS=1 ./node-c4aa34aa --version 2>&1 | grep "looking for weak-def symbol" | wc -l
    7317
$ DYLD_PRINT_BINDINGS=1 out/Release/node --version 2>&1 | grep "looking for weak-def symbol" | wc -l
    1755

$ hyperfine "./node-c4aa34aa --version" "out/Release/node --version" --warmup 10
Benchmark 1: ./node-c4aa34aa --version
  Time (mean ± σ):      28.9 ms ±   1.0 ms    [User: 26.5 ms, System: 1.9 ms]
  Range (min … max):    28.1 ms …  32.2 ms    89 runs

Benchmark 2: out/Release/node --version
  Time (mean ± σ):      12.4 ms ±   1.0 ms    [User: 9.1 ms, System: 1.9 ms]
  Range (min … max):    11.6 ms …  16.2 ms    148 runs

Summary
  'out/Release/node --version' ran
    2.33 ± 0.20 times faster than './node-c4aa34aa --version'

$ ls -lah out/Release/node
-rwxr-xr-x  1 joyee  staff   108M Dec 16 22:39 out/Release/node
$ ls -lah ./node-c4aa34aa
-rwxr-xr-x  1 joyee  staff   118M Dec  5 12:39 ./node-c4aa34aa

On Linux the performance is mostly the same as Linux's ld doesn't resolve the weak symbols like macOS's dyld does in the first place, so there was no regression to fix. This does however makes the binary a bit smaller. EDIT: split out the non-macOS settings to #56290 since it seems to cause gcc to time out or run out of memory on some machines in the CI, possibly because it invalidates the ccache on too many machines.

$ hyperfine "./node-hidden ./test/fixtures/empty.js" "./node-main ./test/fixtures/empty.js" --warmup=10
Benchmark 1: ./node-hidden ./test/fixtures/empty.js
  Time (mean ± σ):      18.0 ms ±   0.3 ms    [User: 10.0 ms, System: 8.4 ms]
  Range (min … max):    17.2 ms …  18.7 ms    165 runs

Benchmark 2: ./node-main ./test/fixtures/empty.js
  Time (mean ± σ):      18.4 ms ±   0.3 ms    [User: 9.8 ms, System: 8.9 ms]
  Range (min … max):    17.7 ms …  19.1 ms    158 runs

Summary
  './node-hidden ./test/fixtures/empty.js' ran
    1.02 ± 0.02 times faster than './node-main ./test/fixtures/empty.js'

$ ls -lah ./node-main ./node-hidden
-rwxrwxr-x 1 ubuntu ubuntu 113M Dec 16 23:05 ./node-hidden
-rwxrwxr-x 1 ubuntu ubuntu 121M Dec 16 23:59 ./node-main

Fixes: nodejs/performance#180

nodejs-github-bot · 2024-12-16T21:44:05Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

juanarbol

Impressive catch, thank you.

Rubber stamp LGTM

nodejs-github-bot · 2024-12-16T21:55:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64071/

nodejs-github-bot · 2024-12-16T21:55:20Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6324/

nodejs-github-bot · 2024-12-16T21:55:49Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6324/

nodejs-github-bot · 2024-12-16T21:56:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6324/

lemire · 2024-12-16T22:08:22Z

Looks like great work! Congratulations!

joyeecheung · 2024-12-17T00:08:35Z

Updated to also apply the flag to Linux. The performance profile on Linux stays the same since Linux didn't have that regression in the first place, though this does shrink the binary by about 8MB.

joyeecheung · 2024-12-17T01:01:23Z

Added BUILDING_V8_SHARED to fix the addon tests since we'll now need V8_EXPORT to explicitly mark the symbols as visible.

lemire · 2024-12-17T01:01:59Z

Someone should give Joyee an award for this PR.

nodejs-github-bot · 2024-12-17T01:33:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64075/

nodejs-github-bot · 2024-12-17T01:33:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6325/

nodejs-github-bot · 2024-12-17T01:34:43Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6325/

nodejs-github-bot · 2024-12-17T01:35:35Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6325/

anonrig · 2024-12-17T02:52:56Z

I want to approve this PR multiple times just to show my respect.

joyeecheung · 2024-12-17T14:07:41Z

It seems on some Linux configs and on SmartOS, with -fvisibility=hidden gcc is either running out of memory or timing out especially when building turboshaft (my guess is that turning this on might give gcc too much room to optimize which requires resources that not all machines in our CI currently have). I will split out the cflags setting for non-macOS platforms to another PR, and let this PR focus on macOS since that's the only platform where not fixing this leads to a startup regression.

nodejs-github-bot · 2024-12-17T14:18:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64083/

nodejs-github-bot · 2024-12-17T14:18:19Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6327/

nodejs-github-bot · 2024-12-17T14:18:45Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6327/

nodejs-github-bot · 2024-12-17T14:19:39Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6327/

legendecas · 2024-12-17T14:54:58Z

tools/v8_gypfiles/v8.gyp

+      'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',  # -fvisibility=hidden
+    },
+    'defines': [
+      'BUILDING_V8_SHARED',  # Make V8_EXPORT visible.


node/common.gypi

Lines 478 to 479 in 5a868b5

'BUILDING_V8_SHARED=1',

'BUILDING_UV_SHARED=1',

non-blocking: common.gypi probably needs to be consolidated

I think for addons, common.gypi should define USING_V8_SHARED instead, then in node.gypi we need to undefine it/override it to BUILDING_V8_SHARED when building libnode, though that might be a bit challenging to get right with the messy gyp config inheritance all over the place..for now there should probably not even be any difference on Windows (USING_V8_SHARED only affects Windows AFAICT, but currently both the addons and the Node.js build have BUILDING_V8_SHARED on Windows before and after this PR, even though it's technically not quite right for the addons to do that - not that it's going to be buggy, just less optimized). We can look into it in a follow up.

yeah, agreed that addons should have USING_V8_SHARED defined. Right now, it is defined in node-gyp. So here in common.gypi, it may be removed in a follow-up.

https://github.com/nodejs/node-gyp/blob/b899faed56270d3d8496da7576b5750b264c2c21/addon.gypi#L36

joyeecheung · 2024-12-17T17:27:21Z

It seems non-macOS platforms are still timing out, likely due to ccache invalidation (#56290 (comment))? So I changed the config to completely scoped to macOS in this PR - for non-macOS updates I will find a time when the CI is less busy to work on it in #56290

nodejs-github-bot · 2024-12-17T17:36:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64091/

nodejs-github-bot · 2024-12-17T17:36:44Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6328/

nodejs-github-bot · 2024-12-17T17:37:42Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6328/

nodejs-github-bot · 2024-12-17T17:39:07Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6328/

nodejs-github-bot · 2024-12-18T11:15:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64100/

nodejs-github-bot · 2024-12-18T21:17:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64107/

nodejs-github-bot · 2024-12-19T03:24:53Z

Landed in 7560778

V8 should be built with -fvisibility=hidden, otherwise the resulting binary would contain unnecessary symbols. In particular, on macOS, this leads to 5000+ weak symbols resolved at runtime, leading to a startup regression. On macOS this also reduces the binary size about ~10MB. It's only enabled on macOS in this patch as gcc can time out or run out of memory on some machines in the CI with -fvisibility=hidden. PR-URL: #56275 Fixes: nodejs/performance#180 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `23.5.0` -> `23.6.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v23.6.0`](https://github.com/nodejs/node/releases/tag/v23.6.0): 2025-01-07, Version 23.6.0 (Current), @marco-ippolito [Compare Source](nodejs/node@v23.5.0...v23.6.0) ##### Notable Changes ##### Unflagging --experimental-strip-types This release enables the flag `--experimental-strip-types` by default. Node.js will be able to execute TypeScript files without additional configuration: ```bash node file.ts ``` There are some limitations in the supported syntax documented at <https://nodejs.org/api/typescript.html#type-stripping> This feature is experimental and is subject to change. Contributed by Marco Ippolito in [#56350](nodejs/node#56350) ##### Other Notable Changes - \[[`c1023284c3`](nodejs/node@c1023284c3)] - **(SEMVER-MINOR)** **lib**: add typescript support to STDIN eval (Marco Ippolito) [#56359](nodejs/node#56359) - \[[`8dc39e5e2e`](nodejs/node@8dc39e5e2e)] - **(SEMVER-MINOR)** **process**: add process.ref() and process.unref() methods (James M Snell) [#56400](nodejs/node#56400) - \[[`8b20cc212b`](nodejs/node@8b20cc212b)] - **(SEMVER-MINOR)** **worker**: add eval ts input (Marco Ippolito) [#56394](nodejs/node#56394) ##### Commits - \[[`7b4d288116`](nodejs/node@7b4d288116)] - **assert**: make partialDeepStrictEqual throw when comparing \[0] with \[-0] (Giovanni) [#56237](nodejs/node#56237) - \[[`0ec2ed0a0b`](nodejs/node@0ec2ed0a0b)] - **build**: fix GN build for ngtcp2 (Cheng) [#56300](nodejs/node#56300) - \[[`ab3e64630b`](nodejs/node@ab3e64630b)] - **build**: test macos-13 on GitHub actions (Michaël Zasso) [#56307](nodejs/node#56307) - \[[`46fb69daca`](nodejs/node@46fb69daca)] - **build**: build v8 with -fvisibility=hidden on macOS (Joyee Cheung) [#56275](nodejs/node#56275) - \[[`9d4930b993`](nodejs/node@9d4930b993)] - **deps**: update simdutf to 5.7.2 (Node.js GitHub Bot) [#56388](nodejs/node#56388) - \[[`6afe36397e`](nodejs/node@6afe36397e)] - **deps**: update amaro to 0.2.1 (Node.js GitHub Bot) [#56390](nodejs/node#56390) - \[[`195990a0ee`](nodejs/node@195990a0ee)] - **deps**: update googletest to [`7d76a23`](nodejs/node@7d76a23) (Node.js GitHub Bot) [#56387](nodejs/node#56387) - \[[`b9c0852fc6`](nodejs/node@b9c0852fc6)] - **deps**: update googletest to [`e54519b`](nodejs/node@e54519b) (Node.js GitHub Bot) [#56370](nodejs/node#56370) - \[[`eaefd90128`](nodejs/node@eaefd90128)] - **deps**: update ngtcp2 to 1.10.0 (Node.js GitHub Bot) [#56334](nodejs/node#56334) - \[[`06de0c65cf`](nodejs/node@06de0c65cf)] - **deps**: update simdutf to 5.7.0 (Node.js GitHub Bot) [#56332](nodejs/node#56332) - \[[`03df76cdec`](nodejs/node@03df76cdec)] - **doc**: add example for piping ReadableStream (Gabriel Schulhof) [#56415](nodejs/node#56415) - \[[`38ce249b07`](nodejs/node@38ce249b07)] - **doc**: expand description of `parseArg`'s `default` (Kevin Gibbons) [#54431](nodejs/node#54431) - \[[`ecc718cef2`](nodejs/node@ecc718cef2)] - **doc**: use `<ul>` instead of `<ol>` in `SECURITY.md` (Antoine du Hamel) [#56346](nodejs/node#56346) - \[[`3db4809130`](nodejs/node@3db4809130)] - **doc**: clarify that WASM is trusted (Matteo Collina) [#56345](nodejs/node#56345) - \[[`384ccbacd5`](nodejs/node@384ccbacd5)] - **doc**: update macOS and Xcode versions for releases (Michaël Zasso) [#56337](nodejs/node#56337) - \[[`3943986e88`](nodejs/node@3943986e88)] - **doc**: fix the `crc32` documentation (Kevin Toshihiro Uehara) [#55898](nodejs/node#55898) - \[[`710b8fc6ed`](nodejs/node@710b8fc6ed)] - **doc**: add entry to changelog about SQLite Session Extension (Bart Louwers) [#56318](nodejs/node#56318) - \[[`4c978b4d77`](nodejs/node@4c978b4d77)] - **doc**: fix links in `module.md` (Antoine du Hamel) [#56283](nodejs/node#56283) - \[[`cdb631efe7`](nodejs/node@cdb631efe7)] - **esm**: add experimental support for addon modules (Chengzhong Wu) [#55844](nodejs/node#55844) - \[[`db83d2f0ee`](nodejs/node@db83d2f0ee)] - ***Revert*** "**events**: add hasEventListener util for validate" (origranot) [#56282](nodejs/node#56282) - \[[`c2baae84ce`](nodejs/node@c2baae84ce)] - **lib**: refactor execution.js (Marco Ippolito) [#56358](nodejs/node#56358) - \[[`c1023284c3`](nodejs/node@c1023284c3)] - **(SEMVER-MINOR)** **lib**: add typescript support to STDIN eval (Marco Ippolito) [#56359](nodejs/node#56359) - \[[`e4b795ec4a`](nodejs/node@e4b795ec4a)] - **lib**: optimize `prepareStackTrace` on builtin frames (Chengzhong Wu) [#56299](nodejs/node#56299) - \[[`d1b009b623`](nodejs/node@d1b009b623)] - **lib**: suppress source map lookup exceptions (Chengzhong Wu) [#56299](nodejs/node#56299) - \[[`c2837f0805`](nodejs/node@c2837f0805)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#56342](nodejs/node#56342) - \[[`72336233f2`](nodejs/node@72336233f2)] - **meta**: move MoLow to TSC regular member (Moshe Atlow) [#56276](nodejs/node#56276) - \[[`4f77920a9d`](nodejs/node@4f77920a9d)] - **module**: fix async resolution error within the sync `findPackageJSON` (Jacob Smith) [#56382](nodejs/node#56382) - \[[`e5ba216501`](nodejs/node@e5ba216501)] - **(SEMVER-MINOR)** **module**: unflag --experimental-strip-types (Marco Ippolito) [#56350](nodejs/node#56350) - \[[`959f133a22`](nodejs/node@959f133a22)] - **module**: support eval with ts syntax detection (Marco Ippolito) [#56285](nodejs/node#56285) - \[[`717cfa4fac`](nodejs/node@717cfa4fac)] - **module**: use buffer.toString base64 (Chengzhong Wu) [#56315](nodejs/node#56315) - \[[`c2f4d8d688`](nodejs/node@c2f4d8d688)] - **node-api**: define version 10 (Gabriel Schulhof) [#55676](nodejs/node#55676) - \[[`417a8ebdec`](nodejs/node@417a8ebdec)] - **node-api**: remove deprecated attribute from napi_module_register (Vladimir Morozov) [#56162](nodejs/node#56162) - \[[`8dc39e5e2e`](nodejs/node@8dc39e5e2e)] - **(SEMVER-MINOR)** **process**: add process.ref() and process.unref() methods (James M Snell) [#56400](nodejs/node#56400) - \[[`d194f1ab5f`](nodejs/node@d194f1ab5f)] - **sqlite**: pass conflict type to conflict resolution handler (Bart Louwers) [#56352](nodejs/node#56352) - \[[`29f5d70452`](nodejs/node@29f5d70452)] - **src**: use v8::LocalVector consistently with other minor cleanups (James M Snell) [#56417](nodejs/node#56417) - \[[`2a5543b78e`](nodejs/node@2a5543b78e)] - **src**: use starts_with in fs_permission.cc (ishabi) [#55811](nodejs/node#55811) - \[[`3a3f5c9a64`](nodejs/node@3a3f5c9a64)] - **stream**: validate undefined sizeAlgorithm in WritableStream (Jason Zhang) [#56067](nodejs/node#56067) - \[[`6e6f6b071a`](nodejs/node@6e6f6b071a)] - **test**: add ts eval snapshots (Marco Ippolito) [#56358](nodejs/node#56358) - \[[`8a87e39052`](nodejs/node@8a87e39052)] - **test**: remove empty lines from snapshots (Marco Ippolito) [#56358](nodejs/node#56358) - \[[`510649f617`](nodejs/node@510649f617)] - **test**: use unusual chars in the path to ensure our tests are robust (Antoine du Hamel) [#48409](nodejs/node#48409) - \[[`54f6d681a0`](nodejs/node@54f6d681a0)] - **test**: remove flaky designation (Luigi Pinca) [#56369](nodejs/node#56369) - \[[`20ace0bb01`](nodejs/node@20ace0bb01)] - **test**: remove test-worker-arraybuffer-zerofill flaky designation (Luigi Pinca) [#56364](nodejs/node#56364) - \[[`b757e40525`](nodejs/node@b757e40525)] - **test**: remove test-net-write-fully-async-hex-string flaky designation (Luigi Pinca) [#56365](nodejs/node#56365) - \[[`64556baddc`](nodejs/node@64556baddc)] - **test**: improve abort signal dropping test (Edy Silva) [#56339](nodejs/node#56339) - \[[`accbdad329`](nodejs/node@accbdad329)] - **test**: enable ts test on win arm64 (Marco Ippolito) [#56349](nodejs/node#56349) - \[[`4188ee00d1`](nodejs/node@4188ee00d1)] - **test**: deflake test-watch-file-shared-dependency (Luigi Pinca) [#56344](nodejs/node#56344) - \[[`079cee0609`](nodejs/node@079cee0609)] - **test**: skip `test-sqlite-extensions` when SQLite is not built by us (Antoine du Hamel) [#56341](nodejs/node#56341) - \[[`96a38044ee`](nodejs/node@96a38044ee)] - **test**: increase spin for eventloop test on s390 (Michael Dawson) [#56228](nodejs/node#56228) - \[[`c062ffc242`](nodejs/node@c062ffc242)] - **test**: add coverage for pipeline (jakecastelli) [#56278](nodejs/node#56278) - \[[`d4404f0d0e`](nodejs/node@d4404f0d0e)] - **test**: migrate message eval tests from Python to JS (Yiyun Lei) [#50482](nodejs/node#50482) - \[[`9369942745`](nodejs/node@9369942745)] - **test**: check typescript loader (Marco Ippolito) [#54657](nodejs/node#54657) - \[[`4930244484`](nodejs/node@4930244484)] - **test**: remove async-hooks/test-writewrap flaky designation (Luigi Pinca) [#56048](nodejs/node#56048) - \[[`7819bfec69`](nodejs/node@7819bfec69)] - **test**: deflake test-esm-loader-hooks-inspect-brk (Luigi Pinca) [#56050](nodejs/node#56050) - \[[`e9762bf005`](nodejs/node@e9762bf005)] - **test**: add test case for listeners (origranot) [#56282](nodejs/node#56282) - \[[`c1627e9d19`](nodejs/node@c1627e9d19)] - **test**: make `test-permission-sqlite-load-extension` more robust (Antoine du Hamel) [#56295](nodejs/node#56295) - \[[`97d854e1d5`](nodejs/node@97d854e1d5)] - **test_runner,cli**: mark test isolation as stable (Colin Ihrig) [#56298](nodejs/node#56298) - \[[`a4f336fdd4`](nodejs/node@a4f336fdd4)] - **tools**: fix `require-common-first` lint rule from subfolder (Antoine du Hamel) [#56325](nodejs/node#56325) - \[[`dc3dafcb50`](nodejs/node@dc3dafcb50)] - **tools**: add release line label when opening release proposal (Antoine du Hamel) [#56317](nodejs/node#56317) - \[[`2a5ac932ac`](nodejs/node@2a5ac932ac)] - **url**: use resolved path to convert UNC paths to URL (Antoine du Hamel) [#56302](nodejs/node#56302) - \[[`8b20cc212b`](nodejs/node@8b20cc212b)] - **(SEMVER-MINOR)** **worker**: add eval ts input (Marco Ippolito) [#56394](nodejs/node#56394) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 16, 2024

juanarbol approved these changes Dec 16, 2024

View reviewed changes

joyeecheung mentioned this pull request Dec 16, 2024

Potential startup regression since on Node.js >= 22 nodejs/performance#180

Closed

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2024

lemire approved these changes Dec 16, 2024

View reviewed changes

RafaelGSS approved these changes Dec 16, 2024

View reviewed changes

joyeecheung force-pushed the v8-visibility branch from b8c972d to 970f133 Compare December 17, 2024 00:01

joyeecheung changed the title ~~build: build v8 with -fvisibility=hidden on macOS~~ build: build v8 with -fvisibility=hidden Dec 17, 2024

anonrig approved these changes Dec 17, 2024

View reviewed changes

joyeecheung force-pushed the v8-visibility branch from 970f133 to 7021192 Compare December 17, 2024 01:00

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024

anonrig approved these changes Dec 17, 2024

View reviewed changes

joyeecheung force-pushed the v8-visibility branch from 7021192 to 3b1bdd4 Compare December 17, 2024 14:05

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024

joyeecheung changed the title ~~build: build v8 with -fvisibility=hidden~~ build: build v8 with -fvisibility=hidden on macOS Dec 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024

joyeecheung mentioned this pull request Dec 17, 2024

build: build v8 with -fvisibility=hidden -fvisibility-inlines-hidden #56290

Open

legendecas approved these changes Dec 17, 2024

View reviewed changes

fixup! build: build v8 with -fvisibility=hidden on macOS

3ee4021

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024

ryanaslett mentioned this pull request Dec 17, 2024

Equinix Move: Rebuild SmartOS Hosts nodejs/build#3731

Open

6 tasks

marco-ippolito approved these changes Dec 18, 2024

View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2024

nodejs-github-bot merged commit 7560778 into nodejs:main Dec 19, 2024
58 checks passed

github-actions bot mentioned this pull request Jan 3, 2025

2025-01-07, Version 23.6.0 (Current) #56450

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: build v8 with -fvisibility=hidden on macOS #56275

build: build v8 with -fvisibility=hidden on macOS #56275

joyeecheung commented Dec 16, 2024 •

edited

Loading

nodejs-github-bot commented Dec 16, 2024

juanarbol left a comment

nodejs-github-bot commented Dec 16, 2024

nodejs-github-bot commented Dec 16, 2024

nodejs-github-bot commented Dec 16, 2024

nodejs-github-bot commented Dec 16, 2024

lemire commented Dec 16, 2024

joyeecheung commented Dec 17, 2024

joyeecheung commented Dec 17, 2024 •

edited

Loading

lemire commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

anonrig commented Dec 17, 2024

joyeecheung commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

legendecas Dec 17, 2024

joyeecheung Dec 17, 2024 •

edited

Loading

legendecas Dec 17, 2024

joyeecheung commented Dec 17, 2024 •

edited

Loading

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 18, 2024

nodejs-github-bot commented Dec 18, 2024

nodejs-github-bot commented Dec 19, 2024

build: build v8 with -fvisibility=hidden on macOS #56275

build: build v8 with -fvisibility=hidden on macOS #56275

Conversation

joyeecheung commented Dec 16, 2024 • edited Loading

nodejs-github-bot commented Dec 16, 2024

juanarbol left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 16, 2024

nodejs-github-bot commented Dec 16, 2024

nodejs-github-bot commented Dec 16, 2024

nodejs-github-bot commented Dec 16, 2024

lemire commented Dec 16, 2024

joyeecheung commented Dec 17, 2024

joyeecheung commented Dec 17, 2024 • edited Loading

lemire commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

anonrig commented Dec 17, 2024

joyeecheung commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

legendecas Dec 17, 2024

Choose a reason for hiding this comment

joyeecheung Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

legendecas Dec 17, 2024

Choose a reason for hiding this comment

joyeecheung commented Dec 17, 2024 • edited Loading

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 17, 2024

nodejs-github-bot commented Dec 18, 2024

nodejs-github-bot commented Dec 18, 2024

nodejs-github-bot commented Dec 19, 2024

joyeecheung commented Dec 16, 2024 •

edited

Loading

joyeecheung commented Dec 17, 2024 •

edited

Loading

joyeecheung Dec 17, 2024 •

edited

Loading

joyeecheung commented Dec 17, 2024 •

edited

Loading