Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm: optimize string checks and slicing with direct index access #55435

Closed

Conversation

mertcanaltin
Copy link
Member

Optimize string manipulation by replacing prototype methods with direct index access for improved performance.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (4d6d7d6) to head (5b77adb).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/modules/esm/fetch_module.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55435      +/-   ##
==========================================
- Coverage   88.40%   88.40%   -0.01%     
==========================================
  Files         653      653              
  Lines      187604   187602       -2     
  Branches    36119    36114       -5     
==========================================
- Hits       165849   165843       -6     
+ Misses      14983    14977       -6     
- Partials     6772     6782      +10     
Files with missing lines Coverage Δ
lib/internal/modules/esm/fetch_module.js 43.00% <0.00%> (-0.38%) ⬇️

... and 27 files with indirect coverage changes

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also done in #55407.

@mertcanaltin
Copy link
Member Author

This is also done in #55407.

I'm closing this thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants