esm: optimize string checks and slicing with direct index access

nodejs · Oct 17, 2024 · 6c36de3 · 6c36de3
1 parent 4d6d7d6
commit 6c36de3
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/internal/modules/esm/fetch_module.js b/lib/internal/modules/esm/fetch_module.js
@@ -3,9 +3,6 @@ const {
   ObjectPrototypeHasOwnProperty,
   PromisePrototypeThen,
   SafeMap,
-  StringPrototypeEndsWith,
-  StringPrototypeSlice,
-  StringPrototypeStartsWith,
 } = primordials;
 const {
   Buffer: { concat: BufferConcat },
@@ -248,10 +245,10 @@ allowList.addRange('127.0.0.1', '127.255.255.255');
 async function isLocalAddress(hostname) {
   try {
     if (
-      StringPrototypeStartsWith(hostname, '[') &&
-      StringPrototypeEndsWith(hostname, ']')
+      hostname[0] === '[' &&
+      hostname[hostname.length - 1] === ']'
     ) {
-      hostname = StringPrototypeSlice(hostname, 1, -1);
+      hostname = hostname.slice(1, -1);
     }
     const addr = await dnsLookup(hostname, { order: 'verbatim' });
     const ipv = addr.family === 4 ? 'ipv4' : 'ipv6';