-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update results example to return dataframes from functions, optionally write to file #56
Conversation
console output of script: (enembleperturbation) Zachary.Burnett@hfe07 /scratch2/COASTAL/coastal/save/shared/working/zach/nems_adcirc/run_20210720_large_ensemble
> python ensemble_results_parser.py
|
@zacharyburnettNOAA Your suggestion about creating a CLI sounds great to me. |
@zacharyburnettNOAA My other request would be if we can allow for subsetting by a polygon instead/in addition to the bounding box. Can keep min_depth I suppose and make that infinity by default. Then for passing with CLI could use a .txt file or other to define the polygon. |
… (continue numbering by default)
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 47.72% 48.05% +0.33%
==========================================
Files 8 9 +1
Lines 1075 1207 +132
==========================================
+ Hits 513 580 +67
- Misses 562 627 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…s' into feature/combine_besttrack_results
This is great thank you I will check out that .h5 you produced once on Orion |
@WPringle here:
|
moved TODO to #58 |
@WPringle perhaps we can move these functions into the library, and also make a dedicated CLI entry point, maybe
combine_results --output_directory ./runs
or something