Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nethermind: 2.25.4 -> 2.30.3 #562

Closed
wants to merge 3 commits into from

Conversation

bbjubjub2494
Copy link
Contributor

@bbjubjub2494 bbjubjub2494 commented Jan 4, 2025

On top of the version bump, I had to fight the derivation a bit.

With projectFile = "src/Nethermind/Nethermind.sln";, there are some errors. The Nixpkgs Manual, Packaging a dotNET application advises against putting solution files in this variable.

The .nix format for nuget deps is deprecated so I took the opportunity to upgrade. nevermind (ha!)

One slightly annoying thing is that one of the dependencies, System.CommandLine v2.0.0-beta4.24517.1 is hosted in the https://pkgs.dev.azure.com repository which doesn't work automatically with nuget-to-nix.

Flake lock file updates:

• Updated input 'devour-flake':
    'github:srid/devour-flake/17b711b9deadbbc5629cb7d2b64cf86ae72af3fa?narHash=sha256-Vey9n9hIlWiSAZ6CCTpkrL6jt4r2JvT2ik9wa2bjeC0%3D' (2024-03-08)
  → 'github:srid/devour-flake/017e3a0eb62e2a3d63fb20c5028af71f39a81181?narHash=sha256-RrSH%2B9vlDDDh%2ByZao012bvV8Hoej/5poQQYfYlEr6Zw%3D' (2024-12-03)
• Updated input 'devshell':
    'github:numtide/devshell/1ebbe68d57457c8cae98145410b164b5477761f4?narHash=sha256-Q0OEFqe35fZbbRPPRdrjTUUChKVhhWXz3T9ZSKmaoVY%3D' (2024-06-03)
  → 'github:numtide/devshell/dd6b80932022cea34a019e2bb32f6fa9e494dfef?narHash=sha256-xRJ2nPOXb//u1jaBnDP56M7v5ldavjbtR6lfGqSvcKg%3D' (2024-10-07)
• Removed input 'devshell/flake-utils'
• Updated input 'flake-parts':
    'github:hercules-ci/flake-parts/2a55567fcf15b1b1c7ed712a2c6fadaec7412ea8?narHash=sha256-iKzJcpdXih14qYVcZ9QC9XuZYnPc6T8YImb6dX166kw%3D' (2024-06-01)
  → 'github:hercules-ci/flake-parts/205b12d8b7cd4802fbcb8e8ef6a0f1408781a4f9?narHash=sha256-4pDvzqnegAfRkPwO3wmwBhVi/Sye1mzps0zHWYnP88c%3D' (2024-12-04)
• Updated input 'flake-utils':
    'github:numtide/flake-utils/b1d9ab70662946ef0850d488da1c9019f3a9752a?narHash=sha256-SZ5L6eA7HJ/nmkzGG7/ISclqe6oZdOZTNoesiInkXPQ%3D' (2024-03-11)
  → 'github:numtide/flake-utils/11707dc2f618dd54ca8739b309ec4fc024de578b?narHash=sha256-l0KFg5HjrsfsO/JpG%2Br7fRrqm12kzFHyUHqHCVpMMbI%3D' (2024-11-13)
• Updated input 'foundry-nix':
    'github:shazow/foundry.nix/708c0df1e36b5185a727a3c517a5100e46392792?narHash=sha256-qcXXOnRSl0sGKm7JknntBU4su8/342YKZvjklHsIl%2BQ%3D' (2024-06-03)
  → 'github:shazow/foundry.nix/b0534fca03a058756b4a405aacd5f5059a879673?narHash=sha256-T5rE%2BF85pRWkG7efabISw7ZNLgCBhnAg6egu5uGT4Bg%3D' (2024-12-03)
• Updated input 'nixpkgs-unstable':
    'github:nixos/nixpkgs/9c513fc6fb75142f6aec6b7545cb8af2236b80f5?narHash=sha256-bu0xbu2Z6DDzA9LGV81yJunIti6r7tjUImeR8orAL/I%3D' (2024-06-25)
  → 'github:nixos/nixpkgs/4989a246d7a390a859852baddb1013f825435cee?narHash=sha256-kMBQ5PRiFLagltK0sH%2B08aiNt3zGERC2297iB6vrvlU%3D' (2024-12-17)
• Updated input 'treefmt-nix':
    'github:numtide/treefmt-nix/065a23edceff48f948816b795ea8cc6c0dee7cdf?narHash=sha256-9T9mSY35EZSM1KAwb7K9zwQ78qTlLjosZgtUGnw4rn4%3D' (2024-06-24)
  → 'github:numtide/treefmt-nix/76159fc74eeac0599c3618e3601ac2b980a29263?narHash=sha256-/QceWozrNg915Db9x/Ie5k67n9wKgGdTFng%2BZ1Qw0kE%3D' (2024-12-18)
@ekimber
Copy link
Contributor

ekimber commented Jan 6, 2025

Nice work getting this to compile. I could not get fetch-deps working. I would like to move to 24.11 for this because the current dotnet sdk 9.0.0 is a preview release.

@aldoborrero
Copy link
Collaborator

Nice work @bbjubjub2494 would you mind running treefmt?

@bbjubjub2494
Copy link
Contributor Author

Maybe a PR centered around bumping flake inputs is in order? Then we can iterate with content from this as well as #561

@aldoborrero
Copy link
Collaborator

aldoborrero commented Jan 8, 2025

Ideally, we should bump automatically all inputs with a GitHub Action or something that allows us to keep up without manual intervention.

If I'm not mistaken renovate does support updating flake inputs.

UPDATE: I started the effort on PR #567

@bbjubjub2494
Copy link
Contributor Author

closed in favor of #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants