This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
ENH: Implement DWI equality explicitly #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
previously approved these changes
Apr 15, 2024
|
|
|
@oesteban After having shared some more data (thanks) this can be finished. Now do we stick to the |
effigies
reviewed
May 17, 2024
jhlegarreta
force-pushed
the
OverloadDWIEquality
branch
from
34c960b to
8ce53d6
Compare
jhlegarreta
changed the title
Do not pass the nibabel instance variable to the `get_fdata` method:
call it directly as it is a member of it.
Fixes:
```
File "eddymotion/src/eddymotion/data/dmri.py", line 254, in load
retval.fieldmap = fmapimg.get_fdata(fmapimg, dtype="float32") #fmapimg.get_fdata(dtype="float32")
File "nibabel/dataobj_images.py", line 362, in get_fdata
raise ValueError('caching value should be "fill" or "unchanged"')
ValueError: caching value should be "fill" or "unchanged"
```
jhlegarreta
force-pushed
the
OverloadDWIEquality
branch
from
8ce53d6 to
b2d71a4
Compare
effigies
reviewed
May 19, 2024
jhlegarreta
force-pushed
the
OverloadDWIEquality
branch
2 times, most recently
from
a97f879 to
2945885
Compare
Implement DWI equality explicitly: account for the cases where the properties can be `None` by creating a helper method and exclude the `_filepath` property as it is created using a randomly generated dirname.
jhlegarreta
force-pushed
the
OverloadDWIEquality
branch
from
2945885 to
2002a91
Compare
oesteban
approved these changes
May 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_fdataResolves #95.