Web-client multisig primitives #3246
Open
+889
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change constructor of CommitmentPair to accept a random secret and a commitment instead of serialized bytes.
|
I was not able to bundle the multisig primitives into a separate entry point, unfortunately, as the multisig primitives also use common primitives like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Expose basic primitives for multisig operations through the web-client API.
The primitves are:
Also add a
Address.fromPublicKeys(public_keys, num_signers)method to calculate a multisig address from the participating public keys.These primitives enable the client-side operations of the multisig app with the @nimiq/core package alone and thus remove the need for custom Rust-compiled-to-WASM in both the Multisig App and Keyguard.
This PR does not include what are currently server-side operations, such as aggregating commitments, summing partial signatures or calculating merkle paths. That might get added later in a separate PR (tracked by a separate upcoming issue).
This fixes #1578.
Pull request checklist
clippyandrustfmtwarnings.